Changeset 13446 for trunk/src/bp-groups/screens/single/admin/manage-members.php

Timestamp:

04/04/2023 01:06:03 AM (2 years ago)

Author:

imath

Message:

Use the BP Rewrites API to generate single Groups item links

• Introduce the bp_groups_get_path_chunks() function to build BP Rewrites arguments using a regular array.
• Improve bp_members_get_path_chunks() so that it avoids looking for a custom slug when the chunk is a numeric value.
• Introduce the bp_get_group_manage_url() function to build Group's front-end Admin URLs using BP Rewrites.
• Deprecate bp_group_admin_permalink() & bp_get_group_admin_permalink() in favor of bp_group_manage_url() & bp_get_group_manage_url().
• Replace all remaining usage of bp_get_group_permalink() in favor of bp_get_group_url() or bp_get_group_manage_url().

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/81
See #4954

File:

• trunk/src/bp-groups/screens/single/admin/manage-members.php (modified) (11 diffs)

trunk/src/bp-groups/screens/single/admin/manage-members.php

@@ -15 +15 @@
 function groups_screen_group_admin_manage_members() {
 
-    if ( 'manage-members' != bp_get_group_current_admin_tab() )
+    if ( 'manage-members' != bp_get_group_current_admin_tab() ) {
         return false;
+    }
 
-    if ( ! bp_is_item_admin() )
+    if ( ! bp_is_item_admin() ) {
         return false;
+    }
 
-    $bp = buddypress();
+    $bp       = buddypress();
+    $redirect = bp_get_group_manage_url(
+        groups_get_current_group(),
+        bp_groups_get_path_chunks( array( 'manage-members' ), 'manage' )
+    );
 
     if ( bp_action_variable( 1 ) && bp_action_variable( 2 ) && bp_action_variable( 3 ) ) {
@@ -29 +35 @@
 
             // Check the nonce first.
-            if ( !check_admin_referer( 'groups_promote_member' ) )
+            if ( ! check_admin_referer( 'groups_promote_member' ) ) {
                 return false;
+            }
 
             // Promote a user.
-            if ( !groups_promote_member( $user_id, $bp->groups->current_group->id, $status ) )
+            if ( ! groups_promote_member( $user_id, $bp->groups->current_group->id, $status ) ) {
                 bp_core_add_message( __( 'There was an error when promoting that user. Please try again.', 'buddypress' ), 'error' );
-            else
+            } else {
                 bp_core_add_message( __( 'User promoted successfully', 'buddypress' ) );
+            }
 
             /**
@@ -48 +56 @@
             do_action( 'groups_promoted_member', $user_id, $bp->groups->current_group->id );
 
-            bp_core_redirect( bp_get_group_permalink( groups_get_current_group() ) . 'admin/manage-members/' );
+            bp_core_redirect( $redirect );
         }
     }
@@ -57 +65 @@
 
             // Check the nonce first.
-            if ( !check_admin_referer( 'groups_demote_member' ) )
+            if ( ! check_admin_referer( 'groups_demote_member' ) ) {
                 return false;
+            }
 
             // Stop sole admins from abandoning their group.
             $group_admins = groups_get_group_admins( $bp->groups->current_group->id );
-            if ( 1 == count( $group_admins ) && $group_admins[0]->user_id == $user_id )
+            if ( 1 == count( $group_admins ) && $group_admins[0]->user_id == $user_id ) {
                 bp_core_add_message( __( 'This group must have at least one admin', 'buddypress' ), 'error' );
 
-            // Demote a user.
-            elseif ( !groups_demote_member( $user_id, $bp->groups->current_group->id ) )
+                // Demote a user.
+            } elseif ( ! groups_demote_member( $user_id, $bp->groups->current_group->id ) ) {
                 bp_core_add_message( __( 'There was an error when demoting that user. Please try again.', 'buddypress' ), 'error' );
-            else
+            } else {
                 bp_core_add_message( __( 'User demoted successfully', 'buddypress' ) );
+            }
 
             /**
@@ -81 +91 @@
             do_action( 'groups_demoted_member', $user_id, $bp->groups->current_group->id );
 
-            bp_core_redirect( bp_get_group_permalink( groups_get_current_group() ) . 'admin/manage-members/' );
+            bp_core_redirect( $redirect );
         }
 
@@ -88 +98 @@
 
             // Check the nonce first.
-            if ( !check_admin_referer( 'groups_ban_member' ) )
+            if ( ! check_admin_referer( 'groups_ban_member' ) ) {
                 return false;
+            }
 
             // Ban a user.
-            if ( !groups_ban_member( $user_id, $bp->groups->current_group->id ) )
+            if ( ! groups_ban_member( $user_id, $bp->groups->current_group->id ) ) {
                 bp_core_add_message( __( 'There was an error when banning that user. Please try again.', 'buddypress' ), 'error' );
-            else
+            } else {
                 bp_core_add_message( __( 'User banned successfully', 'buddypress' ) );
+            }
 
             /**
@@ -107 +119 @@
             do_action( 'groups_banned_member', $user_id, $bp->groups->current_group->id );
 
-            bp_core_redirect( bp_get_group_permalink( groups_get_current_group() ) . 'admin/manage-members/' );
+            bp_core_redirect( $redirect );
         }
 
@@ -114 +126 @@
 
             // Check the nonce first.
-            if ( !check_admin_referer( 'groups_unban_member' ) )
+            if ( ! check_admin_referer( 'groups_unban_member' ) ) {
                 return false;
+            }
 
             // Remove a ban for user.
-            if ( !groups_unban_member( $user_id, $bp->groups->current_group->id ) )
+            if ( ! groups_unban_member( $user_id, $bp->groups->current_group->id ) ) {
                 bp_core_add_message( __( 'There was an error when unbanning that user. Please try again.', 'buddypress' ), 'error' );
-            else
+            } else {
                 bp_core_add_message( __( 'User ban removed successfully', 'buddypress' ) );
+            }
 
             /**
@@ -133 +147 @@
             do_action( 'groups_unbanned_member', $user_id, $bp->groups->current_group->id );
 
-            bp_core_redirect( bp_get_group_permalink( groups_get_current_group() ) . 'admin/manage-members/' );
+            bp_core_redirect( $redirect );
         }
 
@@ -140 +154 @@
 
             // Check the nonce first.
-            if ( !check_admin_referer( 'groups_remove_member' ) )
+            if ( ! check_admin_referer( 'groups_remove_member' ) ) {
                 return false;
+            }
 
             // Remove a user.
-            if ( !groups_remove_member( $user_id, $bp->groups->current_group->id ) )
+            if ( ! groups_remove_member( $user_id, $bp->groups->current_group->id ) ) {
                 bp_core_add_message( __( 'There was an error removing that user from the group. Please try again.', 'buddypress' ), 'error' );
-            else
+            } else {
                 bp_core_add_message( __( 'User removed successfully', 'buddypress' ) );
+            }
 
             /**
@@ -159 +175 @@
             do_action( 'groups_removed_member', $user_id, $bp->groups->current_group->id );
 
-            bp_core_redirect( bp_get_group_permalink( groups_get_current_group() ) . 'admin/manage-members/' );
+            bp_core_redirect( $redirect );
         }
     }