Changeset 13446 for trunk/src/bp-groups/classes/class-bp-groups-group-members-template.php

Timestamp:

04/04/2023 01:06:03 AM (4 years ago)

Author:

imath

Message:

Use the BP Rewrites API to generate single Groups item links

• Introduce the bp_groups_get_path_chunks() function to build BP Rewrites arguments using a regular array.
• Improve bp_members_get_path_chunks() so that it avoids looking for a custom slug when the chunk is a numeric value.
• Introduce the bp_get_group_manage_url() function to build Group's front-end Admin URLs using BP Rewrites.
• Deprecate bp_group_admin_permalink() & bp_get_group_admin_permalink() in favor of bp_group_manage_url() & bp_get_group_manage_url().
• Replace all remaining usage of bp_get_group_permalink() in favor of bp_get_group_url() or bp_get_group_manage_url().

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/81
See #4954

File:

• trunk/src/bp-groups/classes/class-bp-groups-group-members-template.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-group-members-template.php

@@ -169 +169 @@
 
                 // Assemble the base URL for pagination.
-                $base_url = trailingslashit( bp_get_group_permalink( $current_group ) . bp_current_action() );
+                $chunks = array( bp_current_action() );
                 if ( bp_action_variable() ) {
-                        $base_url = trailingslashit( $base_url . bp_action_variable() );
-                }
+                        $chunks[] = bp_action_variable();
+                }
+
+                $base_url = bp_get_group_url(
+                        $current_group,
+                        bp_groups_get_path_chunks( $chunks )
+                );
 
                 $members_args = $r;