Changeset 13446 for trunk/src/bp-groups/bp-groups-notifications.php

Timestamp:

04/04/2023 01:06:03 AM (2 years ago)

Author:

imath

Message:

Use the BP Rewrites API to generate single Groups item links

• Introduce the bp_groups_get_path_chunks() function to build BP Rewrites arguments using a regular array.
• Improve bp_members_get_path_chunks() so that it avoids looking for a custom slug when the chunk is a numeric value.
• Introduce the bp_get_group_manage_url() function to build Group's front-end Admin URLs using BP Rewrites.
• Deprecate bp_group_admin_permalink() & bp_get_group_admin_permalink() in favor of bp_group_manage_url() & bp_get_group_manage_url().
• Replace all remaining usage of bp_get_group_permalink() in favor of bp_get_group_url() or bp_get_group_manage_url().

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/81
See #4954

File:

• trunk/src/bp-groups/bp-groups-notifications.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-notifications.php

@@ -161 +161 @@
     }
 
-    $group = groups_get_group( $group_id );
-    $args  = array(
+    $group       = groups_get_group( $group_id );
+    $path_chunks = bp_groups_get_path_chunks( array( 'membership-requests' ), 'manage' );
+    $args        = array(
         'tokens' => array(
             'admin.id'             => $admin_id,
@@ -168 +169 @@
             'group.name'           => $group->name,
             'group.id'             => $group_id,
-            'group-requests.url'   => esc_url( bp_get_group_permalink( $group ) . 'admin/membership-requests' ),
+            'group-requests.url'   => esc_url( bp_get_group_manage_url( $group, $path_chunks ) ),
             'profile.url'          => esc_url( bp_members_get_user_url( $requesting_user_id ) ),
             'requesting-user.id'   => $requesting_user_id,