Changeset 13443 for trunk/src/bp-xprofile/bp-xprofile-template.php

Timestamp:

03/31/2023 05:26:39 PM (3 years ago)

Author:

imath

Message:

Make sure all displayed user URLs are built using the BP Rewrites API

Replace all remaining bp_displayed_user_domain() usage in favor of
bp_displayed_user_url().
Introduce the bp_members_get_path_chunks() function to quickly build BP
Rewrites argument for member's URL using an array of slugs.
Deprecate bp_activities_member_rss_link(), bp_blogs_blog_tabs() &
bp_groups_header_tabs().
Improve bp_displayed_user_link() so that it's possible to pass an array
of slugs to output an escaped BP Rewrites ready URL.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/79
See #4954

File:

• trunk/src/bp-xprofile/bp-xprofile-template.php (modified) (4 diffs)

trunk/src/bp-xprofile/bp-xprofile-template.php

@@ -390 +390 @@
 
                 // Build the form action URL.
-                $form_action = trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit/group/' . $group->id );
+                $profile_slug = bp_get_profile_slug();
+                $path_chunks  = array(
+                        'single_item_component'        => bp_rewrites_get_slug( 'members', 'member_' . $profile_slug, $profile_slug ),
+                        'single_item_action'           => bp_rewrites_get_slug( 'members', 'member_' . $profile_slug . '_edit', 'edit' ),
+                        'single_item_action_variables' => array( bp_rewrites_get_slug( 'members', 'member_' . $profile_slug . '_edit_group', 'group' ), $group->id ),
+                );
+                $form_action = bp_displayed_user_url( $path_chunks );
 
                 /**
@@ -1074 +1080 @@
 
                 // Build the profile field group link.
-                $link   = trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit/group/' . $groups[ $i ]->id );
+                $profile_slug = bp_get_profile_slug();
+                $path_chunks  = array(
+                        'single_item_component'        => bp_rewrites_get_slug( 'members', 'member_' . $profile_slug, $profile_slug ),
+                        'single_item_action'           => bp_rewrites_get_slug( 'members', 'member_' . $profile_slug . '_edit', 'edit' ),
+                        'single_item_action_variables' => array( bp_rewrites_get_slug( 'members', 'member_' . $profile_slug . '_edit_group', 'group' ), $groups[ $i ]->id ),
+                );
+                $link         = bp_displayed_user_url( $path_chunks );
 
                 // Add tab to end of tabs array.
@@ -1232 +1244 @@
  */
 function bp_edit_profile_button() {
+        $profile_slug = bp_get_profile_slug();
+        $path_chunks  = array(
+                'single_item_component' => bp_rewrites_get_slug( 'members', 'member_' . $profile_slug, $profile_slug ),
+                'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_' . $profile_slug . '_edit', 'edit' ),
+        );
+
         bp_button( array(
                 'id'                => 'edit_profile',
@@ -1237 +1255 @@
                 'must_be_logged_in' => true,
                 'block_self'        => true,
-                'link_href'         => trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit' ),
+                'link_href'         => bp_displayed_user_url( $path_chunks ),
                 'link_class'        => 'edit',
                 'link_text'         => __( 'Edit Profile', 'buddypress' ),