Changeset 13443 for trunk/src/bp-messages/bp-messages-template.php

Timestamp:

03/31/2023 05:26:39 PM (2 years ago)

Author:

imath

Message:

Make sure all displayed user URLs are built using the BP Rewrites API

Replace all remaining bp_displayed_user_domain() usage in favor of
bp_displayed_user_url().
Introduce the bp_members_get_path_chunks() function to quickly build BP
Rewrites argument for member's URL using an array of slugs.
Deprecate bp_activities_member_rss_link(), bp_blogs_blog_tabs() &
bp_groups_header_tabs().
Improve bp_displayed_user_link() so that it's possible to pass an array
of slugs to output an escaped BP Rewrites ready URL.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/79
See #4954

File:

• trunk/src/bp-messages/bp-messages-template.php (modified) (5 diffs)

trunk/src/bp-messages/bp-messages-template.php

@@ -973 +973 @@
      */
     function bp_get_messages_form_action() {
+        $path_chunks = bp_members_get_path_chunks( array( bp_get_messages_slug(), bp_current_action(), bp_action_variable( 0 ) ) );
+        $url         = bp_displayed_user_url( $path_chunks );
 
         /**
@@ -979 +981 @@
          * @since 1.0.0
          *
-         * @param string $value The form action.
-         */
-        return apply_filters( 'bp_get_messages_form_action', trailingslashit( bp_displayed_user_domain() . bp_get_messages_slug() . '/' . bp_current_action() . '/' . bp_action_variable( 0 ) ) );
+         * @param string $url The form action.
+         */
+        return apply_filters( 'bp_get_messages_form_action',$url );
     }
 
@@ -2299 +2301 @@
      */
     function bp_get_the_thread_delete_link() {
+        $path_chunks = bp_members_get_path_chunks( array( bp_get_messages_slug(), 'inbox', 'delete', bp_get_the_thread_id() ) );
+        $url         = wp_nonce_url( bp_displayed_user_url( $path_chunks ), 'messages_delete_thread' );
 
         /**
@@ -2305 +2309 @@
          * @since 1.0.0
          *
-         * @param string $value URL for deleting the current thread.
-         * @param string $value Text indicating action being executed.
-         */
-        return apply_filters( 'bp_get_message_thread_delete_link', wp_nonce_url( bp_displayed_user_domain() . bp_get_messages_slug() . '/inbox/delete/' . bp_get_the_thread_id(), 'messages_delete_thread' ) );
+         * @param string $url URL for deleting the current thread.
+         */
+        return apply_filters( 'bp_get_message_thread_delete_link', $url );
     }
 
@@ -2327 +2330 @@
      */
     function bp_get_the_thread_exit_link() {
+        $path_chunks = bp_members_get_path_chunks( array( bp_get_messages_slug(), 'inbox', 'exit', bp_get_the_thread_id() ) );
+        $url         = wp_nonce_url( bp_displayed_user_url( $path_chunks ), 'bp_messages_exit_thread' );
 
         /**
          * Filters the URL to exit the current thread.
          *
-         * @since 1.0.0
-         *
-         * @param string $value URL to exit the current thread.
-         * @param string $value Text indicating action being executed.
-         */
-        return apply_filters( 'bp_get_the_thread_exit_link', wp_nonce_url( bp_displayed_user_domain() . bp_get_messages_slug() . '/inbox/exit/' . bp_get_the_thread_id(), 'bp_messages_exit_thread' ) );
+         * @since 10.0.0
+         *
+         * @param string $url URL to exit the current thread.
+         */
+        return apply_filters( 'bp_get_the_thread_exit_link', $url );
     }