Changeset 13443 for trunk/src/bp-messages/actions/bulk-manage.php

Timestamp:

03/31/2023 05:26:39 PM (3 years ago)

Author:

imath

Message:

Make sure all displayed user URLs are built using the BP Rewrites API

Replace all remaining bp_displayed_user_domain() usage in favor of
bp_displayed_user_url().
Introduce the bp_members_get_path_chunks() function to quickly build BP
Rewrites argument for member's URL using an array of slugs.
Deprecate bp_activities_member_rss_link(), bp_blogs_blog_tabs() &
bp_groups_header_tabs().
Improve bp_displayed_user_link() so that it's possible to pass an array
of slugs to output an escaped BP Rewrites ready URL.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/79
See #4954

File:

• trunk/src/bp-messages/actions/bulk-manage.php (modified) (3 diffs)

trunk/src/bp-messages/actions/bulk-manage.php

@@ -22 +22 @@
     }
 
-    $action   = ! empty( $_POST['messages_bulk_action'] ) ? $_POST['messages_bulk_action'] : '';
-    $nonce    = ! empty( $_POST['messages_bulk_nonce'] ) ? $_POST['messages_bulk_nonce'] : '';
-    $messages = ! empty( $_POST['message_ids'] ) ? $_POST['message_ids'] : '';
-    $messages = wp_parse_id_list( $messages );
+    $action      = ! empty( $_POST['messages_bulk_action'] ) ? $_POST['messages_bulk_action'] : '';
+    $nonce       = ! empty( $_POST['messages_bulk_nonce'] ) ? $_POST['messages_bulk_nonce'] : '';
+    $messages    = ! empty( $_POST['message_ids'] ) ? $_POST['message_ids'] : '';
+    $messages    = wp_parse_id_list( $messages );
+    $path_chunks = bp_members_get_path_chunks( array( bp_get_messages_slug(), bp_current_action() ) );
+    $redirect    = bp_displayed_user_url( $path_chunks );
 
     // Bail if no action or no IDs.
     if ( ( ! in_array( $action, array( 'delete', 'read', 'unread' ), true ) ) || empty( $messages ) || empty( $nonce ) ) {
-        bp_core_redirect( bp_displayed_user_domain() . bp_get_messages_slug() . '/' . bp_current_action() . '/' );
+        bp_core_redirect( $redirect );
     }
 
@@ -41 +43 @@
         if ( ! messages_check_thread_access( $message ) && ! bp_current_user_can( 'bp_moderate' ) ) {
             bp_core_add_message( __( 'There was a problem managing your messages.', 'buddypress' ), 'error' );
-            bp_core_redirect( bp_displayed_user_domain() . bp_get_messages_slug() . '/' . bp_current_action() . '/' );
+            bp_core_redirect( $redirect );
         }
     }
@@ -70 +72 @@
 
     // Redirect back to message box.
-    bp_core_redirect( bp_displayed_user_domain() . bp_get_messages_slug() . '/' . bp_current_action() . '/' );
+    bp_core_redirect( $redirect );
 }
 add_action( 'bp_actions', 'bp_messages_action_bulk_manage' );