Changeset 13443 for trunk/src/bp-friends/bp-friends-template.php

Timestamp:

03/31/2023 05:26:39 PM (4 years ago)

Author:

imath

Message:

Make sure all displayed user URLs are built using the BP Rewrites API

Replace all remaining bp_displayed_user_domain() usage in favor of
bp_displayed_user_url().
Introduce the bp_members_get_path_chunks() function to quickly build BP
Rewrites argument for member's URL using an array of slugs.
Deprecate bp_activities_member_rss_link(), bp_blogs_blog_tabs() &
bp_groups_header_tabs().
Improve bp_displayed_user_link() so that it's possible to pass an array
of slugs to output an escaped BP Rewrites ready URL.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/79
See #4954

File:

• trunk/src/bp-friends/bp-friends-template.php (modified) (2 diffs)

trunk/src/bp-friends/bp-friends-template.php

@@ -89 +89 @@
                          
                         <span>
-                                <a href="<?php echo trailingslashit( bp_displayed_user_domain() . bp_get_friends_slug() ) ?>">
+                                <a href="<?php bp_displayed_user_link( array( bp_get_friends_slug() ) ); ?>">
                                         <?php esc_html_e( 'See All', 'buddypress' ) ?>
                                 </a>
@@ -203 +203 @@
  */
 function bp_friend_search_form() {
-
-        $action = bp_displayed_user_domain() . bp_get_friends_slug() . '/my-friends/search/';
-        $label  = __( 'Filter Friends', 'buddypress' ); ?>
-
-                <form action="<?php echo $action ?>" id="friend-search-form" method="post">
-
-                        <label for="friend-search-box" id="friend-search-label"><?php echo $label ?></label>
-                        <input type="search" name="friend-search-box" id="friend-search-box" value="<?php echo $value ?>"<?php echo $disabled ?> />
+        $label        = __( 'Filter Friends', 'buddypress' );
+        $friends_slug = bp_get_friends_slug();
+        $action       = bp_displayed_user_url(
+                array(
+                        'single_item_component'        => bp_rewrites_get_slug( 'members', 'member_' . $friends_slug, $friends_slug ),
+                        'single_item_action'           => bp_rewrites_get_slug( 'members', 'member_' . $friends_slug . '_my_friends', 'my-friends' ),
+                        'single_item_action_variables' => array( bp_rewrites_get_slug( 'members', 'member_' . $friends_slug . '_search', 'search' ) ),
+                )
+        );
+        ?>
+
+                <form action="<?php echo esc_url( $action ) ?>" id="friend-search-form" method="post">
+
+                        <label for="friend-search-box" id="friend-search-label"><?php echo esc_html( $label ); ?></label>
+                        <input type="search" name="friend-search-box" id="friend-search-box" value="" />
 
                         <?php wp_nonce_field( 'friends_search', '_wpnonce_friend_search' ) ?>