Changeset 13442 for trunk/src/bp-templates/bp-nouveau/includes/messages/functions.php

Timestamp:

03/27/2023 06:19:06 PM (2 years ago)

Author:

imath

Message:

Improve Components Member's single item navigation generation

• Edit the BP_Component Class so that it globalize navigation items before registering it.
• Introduce bp_get_component_navigations(), a new function that will be used to get Member's single navigation customizable slugs within the BuddyPress settings area.
• Perform all remaining bp_loggedin_user_domain() replacements (55) in favor of the bp_loggedin_user_url() function which uses BP Rewrites to build URLs.
• Improve bp_loggedin_user_link() by adding a new $chunks array of arguments to output escaped URL in templates.
• Adapt some PHPUnit testcases.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/78
See #4954

File:

• trunk/src/bp-templates/bp-nouveau/includes/messages/functions.php (modified) (3 diffs)

trunk/src/bp-templates/bp-nouveau/includes/messages/functions.php

@@ -210 +210 @@
 
 /**
- * @since 3.0.0
+ * Replaces the Notices Compose URL.
+ *
+ * @since 3.0.0
+ *
+ * @param array $admin_nav The WP Admin Nav.
  */
 function bp_nouveau_messages_adjust_admin_nav( $admin_nav ) {
@@ -217 +221 @@
     }
 
-    $user_messages_link = trailingslashit( bp_loggedin_user_domain() . bp_nouveau_get_component_slug( 'messages' ) );
-
     foreach ( $admin_nav as $nav_iterator => $nav ) {
         $nav_id = str_replace( 'my-account-messages-', '', $nav['id'] );
 
         if ( 'notices' === $nav_id ) {
-            $admin_nav[ $nav_iterator ]['href'] = esc_url( add_query_arg( array(
-                'page' => 'bp-notices'
-            ), bp_get_admin_url( 'users.php' ) ) );
+            $admin_nav[ $nav_iterator ]['href'] = esc_url(
+                add_query_arg(
+                    array(
+                        'page' => 'bp-notices',
+                    ),
+                    bp_get_admin_url( 'users.php' )
+                )
+            );
         }
     }
@@ -271 +278 @@
         'total_count'       => 1,
         'content'           => __( 'New sitewide notice', 'buddypress' ),
-        'href'              => bp_loggedin_user_domain(),
+        'href'              => bp_loggedin_user_url(),
     );