Changeset 13442 for trunk/src/bp-templates/bp-nouveau/includes/members/functions.php

Timestamp:

03/27/2023 06:19:06 PM (21 months ago)

Author:

imath

Message:

Improve Components Member's single item navigation generation

• Edit the BP_Component Class so that it globalize navigation items before registering it.
• Introduce bp_get_component_navigations(), a new function that will be used to get Member's single navigation customizable slugs within the BuddyPress settings area.
• Perform all remaining bp_loggedin_user_domain() replacements (55) in favor of the bp_loggedin_user_url() function which uses BP Rewrites to build URLs.
• Improve bp_loggedin_user_link() by adding a new $chunks array of arguments to output escaped URL in templates.
• Adapt some PHPUnit testcases.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/78
See #4954

File:

• trunk/src/bp-templates/bp-nouveau/includes/members/functions.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/includes/members/functions.php

@@ -78 +78 @@
         // If friends component is active and the user has friends
         if ( bp_is_active( 'friends' ) && bp_get_total_friend_count( bp_loggedin_user_id() ) ) {
+            $friends_slug = bp_nouveau_get_component_slug( 'friends' );
+            $path_chunks   = array(
+                'single_item_component' => bp_rewrites_get_slug( 'members', 'member_' . $friends_slug, $friends_slug ),
+                'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_' . $friends_slug . '_my_friends', 'my-friends' ),
+            );
+
             $nav_items['personal'] = array(
                 'component' => 'members',
                 'slug'      => 'personal', // slug is used because BP_Core_Nav requires it, but it's the scope
                 'li_class'  => array(),
-                'link'      => bp_loggedin_user_domain() . bp_nouveau_get_component_slug( 'friends' ) . '/my-friends/',
+                'link'      => bp_loggedin_user_url( $path_chunks ),
                 'text'      => __( 'My Friends', 'buddypress' ),
                 'count'     => bp_get_total_friend_count( bp_loggedin_user_id() ),