Changeset 13442 for trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php

Timestamp:

03/27/2023 06:19:06 PM (19 months ago)

Author:

imath

Message:

Improve Components Member's single item navigation generation

• Edit the BP_Component Class so that it globalize navigation items before registering it.
• Introduce bp_get_component_navigations(), a new function that will be used to get Member's single navigation customizable slugs within the BuddyPress settings area.
• Perform all remaining bp_loggedin_user_domain() replacements (55) in favor of the bp_loggedin_user_url() function which uses BP Rewrites to build URLs.
• Improve bp_loggedin_user_link() by adding a new $chunks array of arguments to output escaped URL in templates.
• Adapt some PHPUnit testcases.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/78
See #4954

File:

• trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php (modified) (2 diffs)

trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php

@@ -4 +4 @@
  *
  * @since 3.0.0
- * @version 10.0.0
+ * @version 12.0.0
  */
 
@@ -115 +115 @@
 
             if ( 1 === $fav_count ) {
+                $activity_slug          = bp_nouveau_get_component_slug( 'activity' );
+                $custom_activity_slug   = bp_rewrites_get_slug( 'members', 'member_' . $activity_slug, $activity_slug );
+                $activity_favorites_url = bp_loggedin_user_url(
+                    array(
+                        'single_item_component' => $custom_activity_slug,
+                        'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_' . $activity_slug . '_favorites', 'favorites' ),
+                    )
+                );
+
                 $response['directory_tab'] = '<li id="activity-favorites" data-bp-scope="favorites" data-bp-object="activity">
-                    <a href="' . bp_loggedin_user_domain() . bp_nouveau_get_component_slug( 'activity' ) . '/favorites/">
+                    <a href="' . esc_url( $activity_favorites_url ). '">
                         ' . esc_html__( 'My Favorites', 'buddypress' ) . '
                     </a>