Changeset 13441 for trunk/src/bp-settings/classes/class-bp-settings-component.php

Timestamp:

03/23/2023 07:35:38 PM (18 months ago)

Author:

imath

Message:

Make BP_Core_Nav generate "BP Rewrites ready" navigation links

• Remove all components $parent_url attributes when setting sub nav items.
• Only use the bp_core_create_nav_link() $link attribute argument & the bp_core_create_subnav_link() $parent_url attribute argument if specified to preserve backward compatibility.
• Migrates the Community search feature so that it uses BP Rewrites.
• Perform some bp_loggedin_user_domain() in favor of bp_loggedin_user_url().
• Update some PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/77
See #4954

File:

• trunk/src/bp-settings/classes/class-bp-settings-component.php (modified) (6 diffs)

trunk/src/bp-settings/classes/class-bp-settings-component.php

@@ -133 +133 @@
     public function setup_nav( $main_nav = array(), $sub_nav = array() ) {
 
-        // Determine user to use.
-        if ( bp_displayed_user_domain() ) {
-            $user_domain = bp_displayed_user_domain();
-        } elseif ( bp_loggedin_user_domain() ) {
-            $user_domain = bp_loggedin_user_domain();
-        } else {
+        // Stop if there is no user displayed or logged in.
+        if ( ! is_user_logged_in() && ! bp_displayed_user_id() ) {
             return;
         }
 
-        $access        = bp_core_can_edit_settings();
-        $slug          = bp_get_settings_slug();
-        $settings_link = trailingslashit( $user_domain . $slug );
+        $access = bp_core_can_edit_settings();
+        $slug   = bp_get_settings_slug();
 
         // Add the settings navigation item.
@@ -160 +155 @@
             'name'            => __( 'General', 'buddypress' ),
             'slug'            => 'general',
-            'parent_url'      => $settings_link,
             'parent_slug'     => $slug,
             'screen_function' => 'bp_settings_screen_general',
@@ -172 +166 @@
             'name'            => __( 'Email', 'buddypress' ),
             'slug'            => 'notifications',
-            'parent_url'      => $settings_link,
             'parent_slug'     => $slug,
             'screen_function' => 'bp_settings_screen_notification',
@@ -184 +177 @@
                 'name'            => __( 'Capabilities', 'buddypress' ),
                 'slug'            => 'capabilities',
-                'parent_url'      => $settings_link,
                 'parent_slug'     => $slug,
                 'screen_function' => 'bp_settings_screen_capabilities',
@@ -206 +198 @@
                 'name'            => __( 'Export Data', 'buddypress' ),
                 'slug'            => 'data',
-                'parent_url'      => $settings_link,
                 'parent_slug'     => $slug,
                 'screen_function' => 'bp_settings_screen_data',
@@ -219 +210 @@
                 'name'            => __( 'Delete Account', 'buddypress' ),
                 'slug'            => 'delete-account',
-                'parent_url'      => $settings_link,
                 'parent_slug'     => $slug,
                 'screen_function' => 'bp_settings_screen_delete_account',