Changeset 13441 for trunk/src/bp-groups/classes/class-bp-group-extension.php

Timestamp:

03/23/2023 07:35:38 PM (18 months ago)

Author:

imath

Message:

Make BP_Core_Nav generate "BP Rewrites ready" navigation links

• Remove all components $parent_url attributes when setting sub nav items.
• Only use the bp_core_create_nav_link() $link attribute argument & the bp_core_create_subnav_link() $parent_url attribute argument if specified to preserve backward compatibility.
• Migrates the Community search feature so that it uses BP Rewrites.
• Perform some bp_loggedin_user_domain() in favor of bp_loggedin_user_url().
• Update some PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/77
See #4954

File:

• trunk/src/bp-groups/classes/class-bp-group-extension.php (modified) (3 diffs)

trunk/src/bp-groups/classes/class-bp-group-extension.php

@@ -737 +737 @@
                 'slug'            => $this->slug,
                 'parent_slug'     => bp_get_current_group_slug(),
-                'parent_url'      => $group_permalink,
                 'position'        => $this->nav_item_position,
                 'item_css_id'     => 'nav-' . $this->slug,
@@ -960 +959 @@
         }
 
-        $screen = $this->screens['edit'];
-
-        $position = isset( $screen['position'] ) ? (int) $screen['position'] : 10;
-        $position += 40;
-
+        $screen        = $this->screens['edit'];
+        $position      = isset( $screen['position'] ) ? (int) $screen['position'] : 10;
+        $position     += 40;
         $current_group = groups_get_current_group();
-        $admin_link    = trailingslashit( bp_get_group_permalink( $current_group ) . 'admin' );
 
         $subnav_args = array(
@@ -972 +968 @@
             'slug'            => $screen['slug'],
             'parent_slug'     => $current_group->slug . '_manage',
-            'parent_url'      => $admin_link,
             'user_has_access' => bp_is_item_admin(),
             'position'        => $position,