Changeset 13441 for trunk/src/bp-groups/bp-groups-adminbar.php

Timestamp:

03/23/2023 07:35:38 PM (22 months ago)

Author:

imath

Message:

Make BP_Core_Nav generate "BP Rewrites ready" navigation links

• Remove all components $parent_url attributes when setting sub nav items.
• Only use the bp_core_create_nav_link() $link attribute argument & the bp_core_create_subnav_link() $parent_url attribute argument if specified to preserve backward compatibility.
• Migrates the Community search feature so that it uses BP Rewrites.
• Perform some bp_loggedin_user_domain() in favor of bp_loggedin_user_url().
• Update some PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/77
See #4954

File:

• trunk/src/bp-groups/bp-groups-adminbar.php (modified) (3 diffs)

trunk/src/bp-groups/bp-groups-adminbar.php

@@ -57 +57 @@
     }
 
+    $manage_screens = bp_get_group_screens( 'manage' );
+
     // Build the Group Admin menus.
     foreach ( $secondary_nav_items as $menu ) {
@@ -66 +68 @@
          * the 'show_in_admin_bar' argument of your edit screen to true
          */
-        if ( $menu->show_in_admin_bar ) {
+        if ( $menu->show_in_admin_bar && isset( $manage_screens[ $menu->slug ] ) ) {
             /* translators: %s the group menu name */
             $title = sprintf( _x( 'Edit Group %s', 'Group WP Admin Bar manage links', 'buddypress' ), $menu->name );
@@ -76 +78 @@
             }
 
-            $wp_admin_bar->add_node( array(
-                'parent' => $bp->group_admin_menu_id,
-                'id'     => $menu->slug,
-                'title'  => $title,
-                'href'   => bp_get_groups_action_link( 'admin/' . $menu->slug )
-            ) );
+            $wp_admin_bar->add_node(
+                array(
+                    'parent' => $bp->group_admin_menu_id,
+                    'id'     => $menu->slug,
+                    'title'  => $title,
+                    'href'   => bp_get_group_url(
+                        $bp->groups->current_group,
+                        array(
+                            'single_item_action'           => bp_rewrites_get_slug( 'groups', 'bp_group_read_admin', 'admin' ),
+                            'single_item_action_variables' => bp_rewrites_get_slug( 'groups', $manage_screens[ $menu->slug ]['rewrite_id'], $menu->slug ),
+                        )
+                    ),
+                )
+            );
         }
     }