Changeset 13441 for trunk/src/bp-core/classes/class-bp-core.php

Timestamp:

03/23/2023 07:35:38 PM (18 months ago)

Author:

imath

Message:

Make BP_Core_Nav generate "BP Rewrites ready" navigation links

• Remove all components $parent_url attributes when setting sub nav items.
• Only use the bp_core_create_nav_link() $link attribute argument & the bp_core_create_subnav_link() $parent_url attribute argument if specified to preserve backward compatibility.
• Migrates the Community search feature so that it uses BP Rewrites.
• Perform some bp_loggedin_user_domain() in favor of bp_loggedin_user_url().
• Update some PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/77
See #4954

File:

• trunk/src/bp-core/classes/class-bp-core.php (modified) (2 diffs)

trunk/src/bp-core/classes/class-bp-core.php

@@ -292 +292 @@
         // Is the logged in user is a mod for the current item?
         bp_update_is_item_mod( false, 'core' );
+
+        /*
+         * As the BP Core component is excluded from the BP Component code
+         * used to set the Rewrite IDs, we need to set it here. As the `search`
+         * word is already a WordPress rewrite tag, we are not adding a custom
+         * rule for this component to avoid messing with it.
+         */
+        $this->rewrite_ids = array(
+            'community_search' => 'bp_search',
+        );
 
         parent::setup_globals(
@@ -401 +411 @@
 
         parent::register_post_statuses();
+    }
+
+    /**
+     * Parse the WP_Query and eventually set the BP Search mechanism.
+     *
+     * Search doesn't have an associated page, so we check for it separately.
+     *
+     * @since 12.0.0
+     *
+     * @param WP_Query $query Required. See BP_Component::parse_query() for
+     *                        description.
+     */
+    public function parse_query( $query ) {
+        $is_search = $query->get( 'pagename' ) === bp_get_search_slug() || ( isset( $_GET['bp_search'] ) && 1 === (int) $_GET['bp_search'] );
+
+        if ( isset( $_POST['search-terms'] ) && $is_search ) {
+            buddypress()->current_component = bp_get_search_slug();
+        }
+
+        parent::parse_query( $query );
     }