Changeset 13441 for trunk/src/bp-core/bp-core-template.php

Timestamp:

03/23/2023 07:35:38 PM (18 months ago)

Author:

imath

Message:

Make BP_Core_Nav generate "BP Rewrites ready" navigation links

• Remove all components $parent_url attributes when setting sub nav items.
• Only use the bp_core_create_nav_link() $link attribute argument & the bp_core_create_subnav_link() $parent_url attribute argument if specified to preserve backward compatibility.
• Migrates the Community search feature so that it uses BP Rewrites.
• Perform some bp_loggedin_user_domain() in favor of bp_loggedin_user_url().
• Update some PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/77
See #4954

File:

• trunk/src/bp-core/bp-core-template.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-template.php

@@ -520 +520 @@
     $url = bp_rewrites_get_url(
         array(
-            'component_id' => bp_get_search_slug(),
+            'component_id'     => 'core',
+            'community_search' => 1,
         )
     );
@@ -3643 +3644 @@
     foreach ( $bp->{$component}->nav->get_item_nav() as $nav_menu ) {
         // Get the correct menu link. See https://buddypress.trac.wordpress.org/ticket/4624.
-        $link = bp_loggedin_user_domain() ? str_replace( bp_loggedin_user_domain(), bp_displayed_user_domain(), $nav_menu->link ) : trailingslashit( bp_displayed_user_domain() . $nav_menu->link );
+        $link = $nav_menu->link;
+        if ( bp_loggedin_user_url() ) {
+            $link = str_replace( bp_loggedin_user_url(), bp_displayed_user_url(), $nav_menu->link );
+        }
 
         // Add this menu.