Changeset 13441 for trunk/src/bp-activity/bp-activity-notifications.php

Timestamp:

03/23/2023 07:35:38 PM (18 months ago)

Author:

imath

Message:

Make BP_Core_Nav generate "BP Rewrites ready" navigation links

• Remove all components $parent_url attributes when setting sub nav items.
• Only use the bp_core_create_nav_link() $link attribute argument & the bp_core_create_subnav_link() $parent_url attribute argument if specified to preserve backward compatibility.
• Migrates the Community search feature so that it uses BP Rewrites.
• Perform some bp_loggedin_user_domain() in favor of bp_loggedin_user_url().
• Update some PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/77
See #4954

File:

• trunk/src/bp-activity/bp-activity-notifications.php (modified) (1 diff)

trunk/src/bp-activity/bp-activity-notifications.php

@@ -30 +30 @@
     $user_id       = $secondary_item_id;
     $user_fullname = bp_core_get_user_displayname( $user_id );
+    $activity_slug = bp_get_activity_slug();
 
     switch ( $action ) {
         case 'new_at_mention':
             $action_filter = 'at_mentions';
-            $link          = bp_loggedin_user_domain() . bp_get_activity_slug() . '/mentions/';
+            $link          = bp_loggedin_user_url(
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_' . $activity_slug, $activity_slug ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_' . $activity_slug . '_mentions', 'mentions' ),
+                )
+            );
 
             /* translators: %s: the current user display name */