Changeset 13437 for trunk/src/bp-groups/bp-groups-admin.php

Timestamp:

03/18/2023 09:42:31 AM (18 months ago)

Author:

imath

Message:

BP Rewrites: start the migration process for the Groups component

• Add rewrite tags & rules for the Groups directory type and the create URLs.
• Introduce bp_get_group_url()/bp_group_url() & to retrieve/output a Groups single item URL using BP Rewrites.
• Introduce bp_get_group_restricted_screens(), bp_get_group_extension_screens() & bp_get_group_screens() to get information about the Groups screens (in particular each screen rewrite ID). These functions will ease slug customizations from the BuddyPress URL settings tab.
• Improve the Group creation process making sure it's using BP Rewrites to build URLs.
• Perform easiest replacements for bp_get_group_permalink()/bp_group_permalink() & bp_get_groups_directory_permalink()/bp_groups_directory_permalink() in favor of bp_get_group_url()/bp_group_url() & bp_get_groups_directory_url()/bp_groups_directory_url()`.
• Improve code formatting & properly escape single group URLs into templates.
• Update impacted Unit Tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/75
See #4954

File:

• trunk/src/bp-groups/bp-groups-admin.php (modified) (5 diffs)

trunk/src/bp-groups/bp-groups-admin.php

@@ -639 +639 @@
     $form_url = remove_query_arg( array( 'action', 'deleted', 'no_admins', 'error', 'error_new', 'success_new', 'error_modified', 'success_modified' ), $_SERVER['REQUEST_URI'] );
     $form_url = add_query_arg( 'action', 'save', $form_url );
+    $create_url = bp_get_groups_directory_url(
+        array(
+            'create_single_item' => 1,
+        )
+    );
 
     /**
@@ -655 +660 @@
 
         <?php if ( is_user_logged_in() && bp_user_can_create_groups() ) : ?>
-            <a class="page-title-action" href="<?php echo trailingslashit( bp_get_groups_directory_permalink() . 'create' ); ?>"><?php _e( 'Add New', 'buddypress' ); ?></a>
+            <a class="page-title-action" href="<?php echo esc_url( $create_url ); ?>"><?php esc_html_e( 'Add New', 'buddypress' ); ?></a>
         <?php endif; ?>
 
@@ -684 +689 @@
                                             <strong><?php esc_html_e( 'Permalink:', 'buddypress' ) ?></strong>
                                             <span id="bp-groups-permalink">
-                                                <?php bp_groups_directory_permalink(); ?> <input type="text" id="bp-groups-slug" name="bp-groups-slug" value="<?php bp_group_slug( $group ); ?>" autocomplete="off"> /
+                                                <?php bp_groups_directory_url(); ?> <input type="text" id="bp-groups-slug" name="bp-groups-slug" value="<?php bp_group_slug( $group ); ?>" autocomplete="off"> /
                                             </span>
-                                            <a href="<?php echo bp_group_permalink( $group ) ?>" class="button button-small" id="bp-groups-visit-group"><?php esc_html_e( 'Visit Group', 'buddypress' ) ?></a>
+                                            <a href="<?php bp_group_url( $group ) ?>" class="button button-small" id="bp-groups-visit-group"><?php esc_html_e( 'Visit Group', 'buddypress' ) ?></a>
                                         </div>
 
@@ -814 +819 @@
     // Prepare the group items for display.
     $bp_groups_list_table->prepare_items();
+    $create_url = bp_get_groups_directory_url(
+        array(
+            'create_single_item' => 1,
+        )
+    );
 
     /**
@@ -831 +841 @@
 
         <?php if ( is_user_logged_in() && bp_user_can_create_groups() ) : ?>
-            <a class="page-title-action" href="<?php echo trailingslashit( bp_get_groups_directory_permalink() . 'create' ); ?>"><?php _e( 'Add New', 'buddypress' ); ?></a>
+            <a class="page-title-action" href="<?php echo esc_url( $create_url ); ?>"><?php esc_html_e( 'Add New', 'buddypress' ); ?></a>
         <?php endif; ?>