Changeset 13436 for trunk/src/bp-messages/bp-messages-template.php

Timestamp:

03/15/2023 08:16:46 AM (21 months ago)

Author:

imath

Message:

Make more BuddyPress generated links ready for BP Rewrites

• Improve the Members component adding permastructs and custom rewrite

rules for registration and activation pages.

• Improve the Blogs component adding custom rewrite rule to handle the

Blogs create page.

• Make a huge progress about replacing all occurrences of

bp_get_root_domain() (45 replacements were performed).

• Deprecate bp_groups_directory_permalink(),

bp_get_groups_directory_permalink(), bp_blogs_directory_permalink() &
bp_get_blogs_directory_permalink() and replace them with these new
functions: bp_groups_directory_url(), bp_get_groups_directory_url(),
bp_blogs_directory_url() & bp_get_blogs_directory_url().

• Although bp_loggedin_user_domain() & bp_displayed_user_domain()

should also be deprecated, we're leaving them as aliases of the right
functions to use. Plugin authors shouldn't use them to build other links
than member's profile home url.

NB: these deprecations are required because these functions were used
to build BuddyPress URLs concatenating URL chunks. Once the BP Classic
plugin will be built we will adapt the code to remove these deprecation
notices.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/73
See #4954

File:

• trunk/src/bp-messages/bp-messages-template.php (modified) (6 diffs)

trunk/src/bp-messages/bp-messages-template.php

@@ -338 +338 @@
         }
 
-        $domain = bp_members_get_user_url( $user_id );
+        $url = bp_members_get_user_url(
+            $user_id,
+            array(
+                'single_item_component'        => bp_rewrites_get_slug( 'members', 'member_messages', bp_get_messages_slug() ),
+                'single_item_action'           => bp_rewrites_get_slug( 'members', 'member_messages_view', 'view' ),
+                'single_item_action_variables' => array( $thread_id ),
+            )
+        );
 
         /**
@@ -347 +354 @@
          * @since 2.9.0 Added the `$user_id` parameter.
          *
-         * @param string $value     Permalink of a particular thread.
+         * @param string $url       Permalink of a particular thread.
          * @param int    $thread_id ID of the thread.
          * @param int    $user_id   ID of the user.
          */
-        return apply_filters( 'bp_get_message_thread_view_link', trailingslashit( $domain . bp_get_messages_slug() . '/view/' . $thread_id ), $thread_id, $user_id );
+        return apply_filters( 'bp_get_message_thread_view_link', $url, $thread_id, $user_id );
     }
 
@@ -383 +390 @@
         }
 
-        $domain = bp_members_get_user_url( $user_id );
+        $current_action_slug         = bp_current_action();
+        $current_action_rewrite_id   = 'member_messages_' . $current_action_slug;
+        $action_variable_delete_slug = bp_rewrites_get_slug( 'members', $current_action_rewrite_id . '_delete', 'delete' );
+
+        $url = bp_members_get_user_url(
+            $user_id,
+            array(
+                'single_item_component'        => bp_rewrites_get_slug( 'members', 'member_messages', bp_get_messages_slug() ),
+                'single_item_action'           => bp_rewrites_get_slug( 'members', $current_action_rewrite_id, $current_action_slug ),
+                'single_item_action_variables' => array( $action_variable_delete_slug, $messages_template->thread->thread_id ),
+            )
+        );
 
         /**
@@ -390 +408 @@
          * @since 1.0.0
          *
-         * @param string $value   URL for deleting the current thread.
+         * @param string $url   URL for deleting the current thread.
          * @param int    $user_id ID of the user relative to whom the link should be generated.
          */
-        return apply_filters( 'bp_get_message_thread_delete_link', wp_nonce_url( trailingslashit( $domain . bp_get_messages_slug() . '/' . bp_current_action() . '/delete/' . $messages_template->thread->thread_id ), 'messages_delete_thread' ), $user_id );
+        return apply_filters( 'bp_get_message_thread_delete_link', wp_nonce_url( $url, 'messages_delete_thread' ), $user_id );
     }
 
@@ -435 +453 @@
         }
 
-        $domain = bp_members_get_user_url( $user_id );
+        $current_action_slug         = bp_current_action();
+        $current_action_rewrite_id   = 'member_messages_' . $current_action_slug;
+        $action_variable_unread_slug = bp_rewrites_get_slug( 'members', $current_action_rewrite_id . '_unread', 'unread' );
 
         // Base unread URL.
-        $url = trailingslashit( $domain . bp_get_messages_slug() . '/' . bp_current_action() . '/unread' );
+        $url = bp_members_get_user_url(
+            $user_id,
+            array(
+                'single_item_component'        => bp_rewrites_get_slug( 'members', 'member_messages', bp_get_messages_slug() ),
+                'single_item_action'           => bp_rewrites_get_slug( 'members', $current_action_rewrite_id, $current_action_slug ),
+                'single_item_action_variables' => array( $action_variable_unread_slug ),
+            )
+        );
 
         // Add the args to the URL.
@@ -497 +524 @@
         }
 
-        $domain = bp_members_get_user_url( $user_id );
+        $current_action_slug         = bp_current_action();
+        $current_action_rewrite_id   = 'member_messages_' . $current_action_slug;
+        $action_variable_read_slug = bp_rewrites_get_slug( 'members', $current_action_rewrite_id . '_read', 'read' );
 
         // Base read URL.
-        $url = trailingslashit( $domain . bp_get_messages_slug() . '/' . bp_current_action() . '/read' );
+        $url = bp_members_get_user_url(
+            $user_id,
+            array(
+                'single_item_component'        => bp_rewrites_get_slug( 'members', 'member_messages', bp_get_messages_slug() ),
+                'single_item_action'           => bp_rewrites_get_slug( 'members', $current_action_rewrite_id, $current_action_slug ),
+                'single_item_action_variables' => array( $action_variable_read_slug ),
+            )
+        );
 
         // Add the args to the URL.