Changeset 13436 for trunk/src/bp-members/bp-members-functions.php

Timestamp:

03/15/2023 08:16:46 AM (2 years ago)

Author:

imath

Message:

Make more BuddyPress generated links ready for BP Rewrites

• Improve the Members component adding permastructs and custom rewrite

rules for registration and activation pages.

• Improve the Blogs component adding custom rewrite rule to handle the

Blogs create page.

• Make a huge progress about replacing all occurrences of

bp_get_root_domain() (45 replacements were performed).

• Deprecate bp_groups_directory_permalink(),

bp_get_groups_directory_permalink(), bp_blogs_directory_permalink() &
bp_get_blogs_directory_permalink() and replace them with these new
functions: bp_groups_directory_url(), bp_get_groups_directory_url(),
bp_blogs_directory_url() & bp_get_blogs_directory_url().

• Although bp_loggedin_user_domain() & bp_displayed_user_domain()

should also be deprecated, we're leaving them as aliases of the right
functions to use. Plugin authors shouldn't use them to build other links
than member's profile home url.

NB: these deprecations are required because these functions were used
to build BuddyPress URLs concatenating URL chunks. Once the BP Classic
plugin will be built we will adapt the code to remove these deprecation
notices.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/73
See #4954

File:

• trunk/src/bp-members/bp-members-functions.php (modified) (4 diffs)

trunk/src/bp-members/bp-members-functions.php

@@ -145 +145 @@
  *
  * @param integer $user_id  The user ID.
- * @param array   $action {
+ * @param array   $path_chunks {
  *     An array of arguments. Optional.
  *
@@ -178 +178 @@
      * Filters the domain for the passed user.
      *
-     * @since 1.0.1
-     * @deprecated 12.0.0
-     *
-     * @param string $domain        Domain for the passed user.
-     * @param int    $user_id       ID of the passed user.
-     * @param string $user_nicename User nicename of the passed user.
-     * @param string $user_login    User login of the passed user.
-     */
-    $url = apply_filters_deprecated( 'bp_core_get_user_domain', array( $url, $user_id, false, false ), '12.0.0', 'bp_members_get_user_url' );
-
-    /**
-     * Filters the domain for the passed user.
-     *
      * @since 12.0.0
      *
@@ -327 +314 @@
         }
     }
-
-    /**
-     * Filters the username based on originally provided user ID.
-     *
-     * @since 1.0.1
-     * @deprecated 12.0.0
-     *
-     * @param string $slug Username determined by user ID.
-     */
-    $slug = apply_filters_deprecated( 'bp_core_get_username', array( $slug ), '12.0.0', 'bp_members_get_user_slug' );
 
     /**
@@ -2547 +2524 @@
     if ( $is_site_creation ) {
         if ( bp_is_active( 'blogs' ) ) {
-            $redirect_to = trailingslashit( bp_get_blogs_directory_permalink() . 'create' );
+            $url = bp_get_blogs_directory_url(
+                array(
+                    'create_single_item' => 1,
+                )
+            );
+
+            $redirect_to = trailingslashit( $url );
         } else {
             // Perform no redirect in this case.