Changeset 13433 for trunk/tests/phpunit/testcases/routing/settings.php

Timestamp:

03/07/2023 04:28:08 AM (23 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/routing/settings.php (modified) (4 diffs)

trunk/tests/phpunit/testcases/routing/settings.php

@@ -6 +6 @@
 class BP_Tests_Routing_Settings extends BP_UnitTestCase {
     protected $old_current_user = 0;
+    protected $permalink_structure = '';
 
     public function set_up() {
@@ -11 +12 @@
 
         $this->old_current_user = get_current_user_id();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
         $this->set_current_user( self::factory()->user->create( array( 'role' => 'subscriber' ) ) );
     }
@@ -17 +19 @@
         parent::tear_down();
         $this->set_current_user( $this->old_current_user );
+        $this->set_permalink_structure( $this->permalink_structure );
     }
 
     function test_member_settings() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_settings_slug() );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_settings', bp_get_settings_slug() ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_settings_general() );
     }
 
     function test_member_settings_notifications() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_settings_slug() . '/notifications' );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_settings', bp_get_settings_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_settings_notifications', 'notifications' ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_settings_notifications() );
     }
@@ -31 +51 @@
     // @todo How best to test this?
     /*function bp_is_user_settings_account_capbilities() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_settings_slug() . '/capabilities' );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_settings', bp_get_settings_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_settings_capabilities', 'capabilities' ),
+                )
+            )
+        );
     }*/
 
     function bp_is_user_settings_account_delete() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_settings_slug() . '/delete-account' );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_settings', bp_get_settings_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_settings_delete_account', 'delete-account' ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_settings_account_delete() );
     }