Changeset 13433 for trunk/tests/phpunit/testcases/routing/activity.php

Timestamp:

03/07/2023 04:28:08 AM (22 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/routing/activity.php (modified) (7 diffs)

trunk/tests/phpunit/testcases/routing/activity.php

@@ -6 +6 @@
 class BP_Tests_Routing_Activity extends BP_UnitTestCase {
     protected $old_current_user = 0;
+    protected $permalink_structure = '';
 
     public function set_up() {
@@ -11 +12 @@
 
         $this->old_current_user = get_current_user_id();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
         $this->set_current_user( self::factory()->user->create( array( 'role' => 'subscriber' ) ) );
     }
@@ -17 +19 @@
         parent::tear_down();
         $this->set_current_user( $this->old_current_user );
+        $this->set_permalink_structure( $this->permalink_structure );
     }
 
     function test_activity_directory() {
+        $this->set_permalink_structure( '/%postname%/' );
         $this->go_to( bp_get_activity_directory_permalink() );
 
@@ -32 +36 @@
      */
     function test_activity_permalink() {
+        $this->set_permalink_structure( '/%postname%/' );
         $a = self::factory()->activity->create();
         $activity = self::factory()->activity->get_object_by_id( $a );
 
-        $url = bp_core_get_user_domain( $activity->user_id ) . bp_get_activity_slug() . '/' . $activity->id . '/';
+        $url = bp_members_get_user_url(
+            $activity->user_id,
+            array(
+                'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+                'single_item_action'    => $activity->id,
+            )
+        );
         $this->go_to( $url );
         $this->assertTrue( bp_is_single_activity() );
@@ -41 +52 @@
 
     function test_member_activity() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_activity_slug() );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_activity() );
     }
 
     function test_member_activity_mentions() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_activity_slug() . '/mentions'  );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_activity_mentions', 'mentions' ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_activity() );
     }
 
     function test_member_activity_favourites() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_activity_slug() . '/favorites'  );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_activity_favorites', 'favorites' ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_activity() );
     }
@@ -59 +96 @@
      */
     function test_member_activity_friends() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_activity_slug() . '/' . bp_get_friends_slug() );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_activity_friends', bp_get_friends_slug() ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_friends_activity() );
     }
@@ -67 +113 @@
      */
     function test_member_activity_groups() {
-        $this->go_to( bp_core_get_user_domain( bp_loggedin_user_id() ) . bp_get_activity_slug() . '/' . bp_get_groups_slug() );
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                bp_loggedin_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_activity_groups', bp_get_groups_slug() ),
+                )
+            )
+        );
         $this->assertTrue( bp_is_user_groups_activity() );
     }