Changeset 13433 for trunk/tests/phpunit/testcases/members/template.php

Timestamp:

03/07/2023 04:28:08 AM (22 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/members/template.php (modified) (4 diffs)

trunk/tests/phpunit/testcases/members/template.php

@@ -4 +4 @@
  */
 class BP_Tests_Members_Template extends BP_UnitTestCase {
+    protected $permalink_structure = '';
+
+    public function set_up() {
+        parent::set_up();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
+    }
+
+    public function tear_down() {
+        $this->set_permalink_structure( $this->permalink_structure );
+
+        parent::tear_down();
+    }
+
     public function test_bp_has_members_include_on_user_page() {
         $u1 = self::factory()->user->create();
         $u2 = self::factory()->user->create();
-
-        $this->go_to( bp_core_get_user_domain( $u1 ) );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to( bp_members_get_user_url( $u1 ) );
 
         global $members_template;
@@ -59 +73 @@
         $old_user = get_current_user_id();
         $this->set_current_user( $u2 );
-
-        $this->go_to( bp_core_get_user_domain( $u2 ) . bp_get_friends_slug() . '/requests/' );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to(
+            bp_members_get_user_url(
+                $u2,
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_friends', bp_get_friends_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_friends_requests', 'requests' ),
+                )
+            )
+        );
         $this->restore_admins();
 
@@ -86 +109 @@
         $old_user = get_current_user_id();
         $this->set_current_user( $u2 );
+        $this->set_permalink_structure( '/%postname%/' );
 
         // For some reason, in all the user switching, the cache gets
@@ -93 +117 @@
         wp_cache_delete( 'bp_user_domain_' . $u2, 'bp' );
 
-        $this->go_to( bp_core_get_user_domain( $u2 ) . bp_get_friends_slug() . '/requests/' );
+        $this->go_to(
+            bp_members_get_user_url(
+                $u2,
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_friends', bp_get_friends_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_friends_requests', 'requests' ),
+                )
+            )
+        );
         $this->restore_admins();