Changeset 13433 for trunk/tests/phpunit/testcases/core/template/bpUserHasAccess.php

Timestamp:

03/07/2023 04:28:08 AM (23 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/core/template/bpUserHasAccess.php (modified) (4 diffs)

trunk/tests/phpunit/testcases/core/template/bpUserHasAccess.php

@@ -5 +5 @@
  */
 class BP_Tests_Core_Template_BpUserHasAccess extends BP_UnitTestCase {
+    protected $permalink_structure = '';
+
+    public function set_up() {
+        parent::set_up();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
+    }
+
+    public function tear_down() {
+        $this->set_permalink_structure( $this->permalink_structure );
+
+        parent::tear_down();
+    }
+
     public function test_should_return_true_for_bp_moderate_user() {
         $users = self::factory()->user->create_many( 2 );
@@ -10 +23 @@
         $this->grant_bp_moderate( $users[0] );
         $this->set_current_user( $users[0] );
+        $this->set_permalink_structure( '/%postname%/' );
 
-        $this->go_to( bp_core_get_user_domain( $users[1] ) );
+        $this->go_to( bp_members_get_user_url( $users[1] ) );
 
         $this->assertTrue( bp_user_has_access( $users[0] ) );
@@ -20 +34 @@
 
         $this->set_current_user( $users[0] );
+        $this->set_permalink_structure( '/%postname%/' );
 
-        $this->go_to( bp_core_get_user_domain( $users[1] ) );
+        $this->go_to( bp_members_get_user_url( $users[1] ) );
 
         $this->assertFalse( bp_user_has_access( $users[0] ) );
@@ -30 +45 @@
 
         $this->set_current_user( $users[0] );
+        $this->set_permalink_structure( '/%postname%/' );
 
-        $this->go_to( bp_core_get_user_domain( $users[0] ) );
+        $this->go_to( bp_members_get_user_url( $users[0] ) );
 
         $this->assertTrue( bp_user_has_access( $users[0] ) );