Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
03/07/2023 04:28:08 AM (14 months ago)
Author:
imath
Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

  1. to deprecate this function
  2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

  1. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/70
See #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/testcases/core/nav/bpGetNavMenuItems.php

    r11737 r13433  
    66 */
    77class BP_Tests_Core_Nav_BpGetNavMenuItems extends BP_UnitTestCase {
     8    protected $permalink_structure = '';
     9
     10    public function set_up() {
     11        parent::set_up();
     12        $this->permalink_structure = get_option( 'permalink_structure', '' );
     13    }
     14
     15    public function tear_down() {
     16        $this->set_permalink_structure( $this->permalink_structure );
     17
     18        parent::tear_down();
     19    }
     20
    821    /**
    922     * @ticket BP7110
     
    1326
    1427        $this->set_current_user( $users[0] );
    15         $user_1_domain = bp_core_get_user_domain( $users[1] );
     28        $this->set_permalink_structure( '/%postname%/' );
     29
     30        $user_1_domain = bp_members_get_user_url( $users[1] );
    1631        $this->go_to( $user_1_domain );
    1732
     
    3752
    3853        $this->set_current_user( 0 );
    39         $user_domain = bp_core_get_user_domain( $user );
     54        $this->set_permalink_structure( '/%postname%/' );
     55
     56        $user_domain = bp_members_get_user_url( $user );
    4057        $this->go_to( $user_domain );
    4158
Note: See TracChangeset for help on using the changeset viewer.