Changeset 13433 for trunk/tests/phpunit/testcases/core/nav/bpGetNavMenuItems.php

Timestamp:

03/07/2023 04:28:08 AM (7 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/core/nav/bpGetNavMenuItems.php (modified) (3 diffs)

trunk/tests/phpunit/testcases/core/nav/bpGetNavMenuItems.php

@@ -6 +6 @@
  */
 class BP_Tests_Core_Nav_BpGetNavMenuItems extends BP_UnitTestCase {
+    protected $permalink_structure = '';
+
+    public function set_up() {
+        parent::set_up();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
+    }
+
+    public function tear_down() {
+        $this->set_permalink_structure( $this->permalink_structure );
+
+        parent::tear_down();
+    }
+
     /**
      * @ticket BP7110
@@ -13 +26 @@
 
         $this->set_current_user( $users[0] );
-        $user_1_domain = bp_core_get_user_domain( $users[1] );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $user_1_domain = bp_members_get_user_url( $users[1] );
         $this->go_to( $user_1_domain );
 
@@ -37 +52 @@
 
         $this->set_current_user( 0 );
-        $user_domain = bp_core_get_user_domain( $user );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $user_domain = bp_members_get_user_url( $user );
         $this->go_to( $user_domain );