Changeset 13433 for trunk/tests/phpunit/testcases/core/nav/bpCoreNewSubnavItem.php

Timestamp:

03/07/2023 04:28:08 AM (3 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/core/nav/bpCoreNewSubnavItem.php (modified) (2 diffs)

trunk/tests/phpunit/testcases/core/nav/bpCoreNewSubnavItem.php

@@ -16 +16 @@
         $this->set_current_user( $u );
 
-        $user_domain = bp_core_get_user_domain( $u );
+        $user_domain = bp_members_get_user_url( $u );
 
         $this->go_to( $user_domain );
@@ -345 +345 @@
         $this->set_current_user( $u );
 
-        $user_domain = bp_core_get_user_domain( $u );
+        $user_domain = bp_members_get_user_url( $u );
 
         // Register a subnav on 'bp_setup_nav' hook early (at priority zero).