Changeset 13433 for trunk/tests/phpunit/testcases/core/nav/bpCoreNewNavItem.php

Timestamp:

03/07/2023 04:28:08 AM (19 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/core/nav/bpCoreNewNavItem.php (modified) (5 diffs)

trunk/tests/phpunit/testcases/core/nav/bpCoreNewNavItem.php

@@ -5 +5 @@
  */
 class BP_Tests_Core_Nav_BpCoreNewNavItem extends BP_UnitTestCase {
+    protected $permalink_structure = '';
+
+    public function set_up() {
+        parent::set_up();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
+    }
+
+    public function tear_down() {
+        $this->set_permalink_structure( $this->permalink_structure );
+
+        parent::tear_down();
+    }
 
     /**
@@ -15 +27 @@
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u );
-
-        $this->go_to( bp_core_get_user_domain( $u ) );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to( bp_members_get_user_url( $u ) );
 
         bp_core_new_nav_item( array(
@@ -29 +42 @@
             'name'                    => 'Foo',
             'slug'                    => 'foo',
-            'link'                    => trailingslashit( bp_core_get_user_domain( $u ) . 'foo' ),
+            'link'                    => bp_members_get_user_url(
+                $u,
+                array(
+                    'single_item_component' => 'foo',
+                )
+            ),
             'css_id'                  => 'foo',
             'show_for_displayed_user' => true,
@@ -147 +165 @@
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u2 );
-
-        $this->go_to( bp_core_get_user_domain( $u ) );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to( bp_members_get_user_url( $u ) );
 
         $expected = array(
@@ -182 +201 @@
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u2 );
-
-        $this->go_to( bp_core_get_user_domain( $u ) );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to( bp_members_get_user_url( $u ) );
 
         bp_core_new_nav_item( array(