Changeset 13433 for trunk/tests/phpunit/testcases/core/nav/bpCoreMaybeHookNewSubnavScreenFunction.php

Timestamp:

03/07/2023 04:28:08 AM (23 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/tests/phpunit/testcases/core/nav/bpCoreMaybeHookNewSubnavScreenFunction.php (modified) (6 diffs)

trunk/tests/phpunit/testcases/core/nav/bpCoreMaybeHookNewSubnavScreenFunction.php

@@ -5 +5 @@
  */
 class BP_Tests_Core_Nav_BpCoreMaybeHookNewSubnavScreenFunction extends BP_UnitTestCase {
+    protected $permalink_structure = '';
+
+    public function set_up() {
+        parent::set_up();
+        $this->permalink_structure = get_option( 'permalink_structure', '' );
+    }
+
+    public function tear_down() {
+        $this->set_permalink_structure( $this->permalink_structure );
+
+        parent::tear_down();
+    }
 
     public function test_user_has_access_true_no_callable_function() {
@@ -57 +69 @@
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u );
-
-        $this->go_to( bp_core_get_user_domain( $u ) );
-
-        $subnav_item = array(
-            'user_has_access' => false,
-        );
-
-        // Just test relevant info
-        $found = bp_core_maybe_hook_new_subnav_screen_function( $subnav_item );
-        $this->assertSame( 'failure', $found['status'] );
-        $this->assertSame( bp_core_get_user_domain( $u ), $found['redirect_args']['root'] );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to( bp_members_get_user_url( $u ) );
+
+        $subnav_item = array(
+            'user_has_access' => false,
+        );
+
+        // Just test relevant info
+        $found = bp_core_maybe_hook_new_subnav_screen_function( $subnav_item );
+        $this->assertSame( 'failure', $found['status'] );
+        $this->assertSame( bp_members_get_user_url( $u ), $found['redirect_args']['root'] );
 
         $this->set_current_user( $old_current_user );
@@ -77 +90 @@
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u1 );
-
-        $this->go_to( bp_core_get_user_domain( $u2 ) );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to( bp_members_get_user_url( $u2 ) );
 
         $old_bp_nav = buddypress()->bp_nav;
@@ -104 +118 @@
 
         $this->assertSame( 'failure', $found['status'] );
-        $this->assertSame( bp_core_get_user_domain( $u2 ), $found['redirect_args']['root'] );
+        $this->assertSame( bp_members_get_user_url( $u2 ), $found['redirect_args']['root'] );
     }
 
@@ -112 +126 @@
         $old_current_user = get_current_user_id();
         $this->set_current_user( $u1 );
-
-        $this->go_to( bp_core_get_user_domain( $u2 ) );
+        $this->set_permalink_structure( '/%postname%/' );
+
+        $this->go_to( bp_members_get_user_url( $u2 ) );
 
         $old_bp_nav = buddypress()->bp_nav;
@@ -140 +155 @@
 
         $this->assertSame( 'failure', $found['status'] );
-        $this->assertSame( bp_core_get_user_domain( $u2 ) . bp_get_activity_slug() . '/', $found['redirect_args']['root'] );
+        $this->assertSame(
+            bp_members_get_user_url(
+                $u2,
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+                )
+            ),
+            $found['redirect_args']['root']
+        );
     }