Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
03/07/2023 04:28:08 AM (14 months ago)
Author:
imath
Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

  1. to deprecate this function
  2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

  1. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/70
See #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-xprofile/bp-xprofile-activity.php

    r13108 r13433  
    5050 */
    5151function bp_xprofile_format_activity_action_updated_profile( $action, $activity ) {
    52 
    53     // Note for translators: The natural phrasing in English, "Joe updated
    54     // his profile", requires that we know Joe's gender, which we don't. If
    55     // your language doesn't have this restriction, feel free to use a more
    56     // natural translation.
    57     $profile_link = trailingslashit( bp_core_get_user_domain( $activity->user_id ) . bp_get_profile_slug() );
     52    /*
     53     * Note for translators: The natural phrasing in English, "Joe updated
     54     * his profile", requires that we know Joe's gender, which we don't. If
     55     * your language doesn't have this restriction, feel free to use a more
     56     * natural translation.
     57     */
     58    $profile_link = bp_members_get_user_url(
     59        $activity->user_id,
     60        array(
     61            'single_item_component' => bp_rewrites_get_slug( 'members', 'member_profile', bp_get_profile_slug() ),
     62        )
     63    );
    5864
    5965    /* translators: %s: user profile link */
     
    247253
    248254    // If we've reached this point, assemble and post the activity item.
    249     $profile_link = trailingslashit( bp_core_get_user_domain( $user_id ) . bp_get_profile_slug() );
     255    $profile_link = bp_members_get_user_url(
     256        $user_id,
     257        array(
     258            'single_item_component' => bp_rewrites_get_slug( 'members', 'member_profile', bp_get_profile_slug() ),
     259        )
     260    );
    250261
    251262    return (bool) xprofile_record_activity( array(
Note: See TracChangeset for help on using the changeset viewer.