Changeset 13433 for trunk/src/bp-xprofile/bp-xprofile-activity.php

Timestamp:

03/07/2023 04:28:08 AM (3 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-xprofile/bp-xprofile-activity.php (modified) (2 diffs)

trunk/src/bp-xprofile/bp-xprofile-activity.php

@@ -50 +50 @@
  */
 function bp_xprofile_format_activity_action_updated_profile( $action, $activity ) {
-
-        // Note for translators: The natural phrasing in English, "Joe updated
-        // his profile", requires that we know Joe's gender, which we don't. If
-        // your language doesn't have this restriction, feel free to use a more
-        // natural translation.
-        $profile_link = trailingslashit( bp_core_get_user_domain( $activity->user_id ) . bp_get_profile_slug() );
+        /*
+         * Note for translators: The natural phrasing in English, "Joe updated
+         * his profile", requires that we know Joe's gender, which we don't. If
+         * your language doesn't have this restriction, feel free to use a more
+         * natural translation.
+         */
+        $profile_link = bp_members_get_user_url(
+                $activity->user_id,
+                array(
+                        'single_item_component' => bp_rewrites_get_slug( 'members', 'member_profile', bp_get_profile_slug() ),
+                )
+        );
 
         /* translators: %s: user profile link */
@@ -247 +253 @@
 
         // If we've reached this point, assemble and post the activity item.
-        $profile_link = trailingslashit( bp_core_get_user_domain( $user_id ) . bp_get_profile_slug() );
+        $profile_link = bp_members_get_user_url(
+                $user_id,
+                array(
+                        'single_item_component' => bp_rewrites_get_slug( 'members', 'member_profile', bp_get_profile_slug() ),
+                )
+        );
 
         return (bool) xprofile_record_activity( array(