Changeset 13433 for trunk/src/bp-notifications/bp-notifications-template.php

Timestamp:

03/07/2023 04:28:08 AM (23 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-notifications/bp-notifications-template.php (modified) (3 diffs)

trunk/src/bp-notifications/bp-notifications-template.php

@@ -63 +63 @@
             $domain  = bp_loggedin_user_domain();
         } else {
-            $domain = bp_core_get_user_domain( (int) $user_id );
+            $domain = bp_members_get_user_url( (int) $user_id );
         }
 
@@ -104 +104 @@
             $domain  = bp_loggedin_user_domain();
         } else {
-            $domain = bp_core_get_user_domain( (int) $user_id );
+            $domain = bp_members_get_user_url( (int) $user_id );
         }
 
@@ -144 +144 @@
             $domain  = bp_loggedin_user_domain();
         } else {
-            $domain = bp_core_get_user_domain( (int) $user_id );
+            $domain = bp_members_get_user_url( (int) $user_id );
         }