Changeset 13433 for trunk/src/bp-messages/bp-messages-template.php

Timestamp:

03/07/2023 04:28:08 AM (23 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-messages/bp-messages-template.php (modified) (5 diffs)

trunk/src/bp-messages/bp-messages-template.php

@@ -338 +338 @@
         }
 
-        $domain = bp_core_get_user_domain( $user_id );
+        $domain = bp_members_get_user_url( $user_id );
 
         /**
@@ -383 +383 @@
         }
 
-        $domain = bp_core_get_user_domain( $user_id );
+        $domain = bp_members_get_user_url( $user_id );
 
         /**
@@ -435 +435 @@
         }
 
-        $domain = bp_core_get_user_domain( $user_id );
+        $domain = bp_members_get_user_url( $user_id );
 
         // Base unread URL.
@@ -497 +497 @@
         }
 
-        $domain = bp_core_get_user_domain( $user_id );
+        $domain = bp_members_get_user_url( $user_id );
 
         // Base read URL.
@@ -1484 +1484 @@
          * @param string $value URL for the Private Message link in member profile headers.
          */
-        return apply_filters( 'bp_get_send_private_message_link', wp_nonce_url( bp_loggedin_user_domain() . bp_get_messages_slug() . '/compose/?r=' . bp_core_get_username( bp_displayed_user_id() ) ) );
+        return apply_filters( 'bp_get_send_private_message_link', wp_nonce_url( bp_loggedin_user_domain() . bp_get_messages_slug() . '/compose/?r=' . bp_members_get_user_slug( bp_displayed_user_id() ) ) );
     }