Changeset 13433 for trunk/src/bp-members/bp-members-template.php

Timestamp:

03/07/2023 04:28:08 AM (2 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-members/bp-members-template.php (modified) (5 diffs)

trunk/src/bp-members/bp-members-template.php

@@ -902 +902 @@
         global $members_template;
 
-        $permalink = bp_core_get_user_domain(
-            $members_template->member->id,
-            $members_template->member->user_nicename,
-            $members_template->member->user_login
-        );
+        $permalink = bp_members_get_user_url( $members_template->member->id );
 
         /**
@@ -2050 +2046 @@
 
         if ( bp_displayed_user_id() ) {
-            $username = bp_core_get_username( bp_displayed_user_id(), $bp->displayed_user->userdata->user_nicename, $bp->displayed_user->userdata->user_login );
+            $username = bp_members_get_user_slug( bp_displayed_user_id() );
         } else {
             $username = '';
@@ -2084 +2080 @@
 
         if ( bp_loggedin_user_id() ) {
-            $username = bp_core_get_username( bp_loggedin_user_id(), $bp->loggedin_user->userdata->user_nicename, $bp->loggedin_user->userdata->user_login );
+            $username = bp_members_get_user_slug( bp_loggedin_user_id() );
         } else {
             $username = '';
@@ -3572 +3568 @@
             $domain  = bp_loggedin_user_domain();
         } else {
-            $domain = bp_core_get_user_domain( (int) $user_id );
+            $domain = bp_members_get_user_url( (int) $user_id );
         }
 
@@ -3611 +3607 @@
             $domain  = bp_loggedin_user_domain();
         } else {
-            $domain = bp_core_get_user_domain( (int) $user_id );
+            $domain = bp_members_get_user_url( (int) $user_id );
         }