Changeset 13433 for trunk/src/bp-members/bp-members-filters.php

Timestamp:

03/07/2023 04:28:08 AM (19 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-members/bp-members-filters.php (modified) (1 diff)

trunk/src/bp-members/bp-members-filters.php

@@ -109 +109 @@
     // If xprofile is active, use profile domain link.
     if ( ! is_admin() && bp_is_active( 'xprofile' ) ) {
-        $profile_link = trailingslashit( bp_core_get_user_domain( $user_id ) . bp_get_profile_slug() . '/edit' );
+        $profile_link = bp_members_get_user_url(
+            $user_id,
+            array(
+                'single_item_component' => bp_rewrites_get_slug( 'members', 'member_profile', bp_get_profile_slug() ),
+                'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_profile_edit', 'edit' ),
+            )
+        );
 
     } else {