Changeset 13433 for trunk/src/bp-groups/bp-groups-template.php

Timestamp:

03/07/2023 04:28:08 AM (4 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-groups/bp-groups-template.php (modified) (6 diffs)

trunk/src/bp-groups/bp-groups-template.php

@@ -1639 +1639 @@
                  * @param BP_Groups_Group $group     The group object.
                  */
-                return apply_filters( 'bp_get_group_creator_permalink', bp_core_get_user_domain( $group->creator_id ), $group );
+                return apply_filters( 'bp_get_group_creator_permalink', bp_members_get_user_url( $group->creator_id ), $group );
         }
 
@@ -1797 +1797 @@
                                 <li>
                                         <a
-                                                href="<?php echo esc_url( bp_core_get_user_domain( $admin->user_id, $admin->user_nicename, $admin->user_login ) ); ?>"
+                                                href="<?php echo esc_url( bp_members_get_user_url( $admin->user_id ) ); ?>"
                                                 class="bp-tooltip"
                                                 data-bp-tooltip="<?php printf( ( '%s' ), bp_core_get_user_displayname( $admin->user_id ) ); ?>"
@@ -1844 +1844 @@
                                 <li>
                                         <a
-                                                href="<?php echo esc_url( bp_core_get_user_domain( $mod->user_id, $mod->user_nicename, $mod->user_login ) ); ?>"
+                                                href="<?php echo esc_url( bp_members_get_user_url( $mod->user_id ) ); ?>"
                                                 class="bp-tooltip"
                                                 data-bp-tooltip="<?php printf( ( '%s' ), bp_core_get_user_displayname( $mod->user_id ) ); ?>">
@@ -4273 +4273 @@
                  * @param string $value URL for the current user.
                  */
-                return apply_filters( 'bp_get_group_member_url', bp_core_get_user_domain( $members_template->member->user_id, $members_template->member->user_nicename, $members_template->member->user_login ) );
+                return apply_filters( 'bp_get_group_member_url', bp_members_get_user_url( $members_template->member->user_id ) );
         }
 
@@ -4297 +4297 @@
                  * @param string $value HTML link for the current user.
                  */
-                return apply_filters( 'bp_get_group_member_link', '<a href="' . bp_core_get_user_domain( $members_template->member->user_id, $members_template->member->user_nicename, $members_template->member->user_login ) . '">' . $members_template->member->display_name . '</a>' );
+                return apply_filters( 'bp_get_group_member_link', '<a href="' . bp_members_get_user_url( $members_template->member->user_id ) . '">' . $members_template->member->display_name . '</a>' );
         }
 
@@ -4321 +4321 @@
                  * @param string $value Domain for the current user.
                  */
-                return apply_filters( 'bp_get_group_member_domain', bp_core_get_user_domain( $members_template->member->user_id, $members_template->member->user_nicename, $members_template->member->user_login ) );
+                return apply_filters( 'bp_get_group_member_domain', bp_members_get_user_url( $members_template->member->user_id ) );
         }