Changeset 13433 for trunk/src/bp-groups/bp-groups-notifications.php

Timestamp:

03/07/2023 04:28:08 AM (2 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-groups/bp-groups-notifications.php (modified) (4 diffs)

trunk/src/bp-groups/bp-groups-notifications.php

@@ -169 +169 @@
             'group.id'             => $group_id,
             'group-requests.url'   => esc_url( bp_get_group_permalink( $group ) . 'admin/membership-requests' ),
-            'profile.url'          => esc_url( bp_core_get_user_domain( $requesting_user_id ) ),
+            'profile.url'          => esc_url( bp_members_get_user_url( $requesting_user_id ) ),
             'requesting-user.id'   => $requesting_user_id,
             'requesting-user.name' => bp_core_get_user_displayname( $requesting_user_id ),
@@ -337 +337 @@
     }
 
-    $invited_link = bp_core_get_user_domain( $invited_user_id ) . bp_get_groups_slug();
+    $invited_link = bp_members_get_user_url(
+        $invited_user_id,
+        array(
+            'single_item_component' => bp_rewrites_get_slug( 'members', 'member_groups', bp_get_groups_slug() ),
+        )
+    );
 
     $unsubscribe_args = array(
@@ -360 +365 @@
             'group.name'     => $group->name,
             'inviter.name'   => bp_core_get_userlink( $inviter_user_id, true, false ),
-            'inviter.url'    => bp_core_get_user_domain( $inviter_user_id ),
+            'inviter.url'    => bp_members_get_user_url( $inviter_user_id ),
             'inviter.id'     => $inviter_user_id,
             'invites.url'    => esc_url( $invited_link . '/invites/' ),
@@ -1252 +1257 @@
             'group.name'      => $group->name,
             'group.url'       => esc_url( bp_get_group_permalink( $group ) ),
-            'leave-group.url' => esc_url( bp_core_get_user_domain( $user_id ) . bp_get_groups_slug() ),
+            'leave-group.url' => esc_url(
+                bp_members_get_user_url(
+                    $user_id,
+                    array(
+                        'single_item_component' => bp_rewrites_get_slug( 'members', 'member_groups', bp_get_groups_slug() ),
+                    )
+                )
+            ),
         ),
     );