Changeset 13433 for trunk/src/bp-friends/bp-friends-functions.php

Timestamp:

03/07/2023 04:28:08 AM (2 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-friends/bp-friends-functions.php (modified) (2 diffs)

trunk/src/bp-friends/bp-friends-functions.php

@@ -878 +878 @@
     $args = array(
         'tokens' => array(
-            'friend-requests.url' => esc_url( bp_core_get_user_domain( $friend_id ) . bp_get_friends_slug() . '/requests/' ),
+            'friend-requests.url' => esc_url(
+                bp_members_get_user_url(
+                    $friend_id,
+                    array(
+                        'single_item_component' => bp_rewrites_get_slug( 'members', 'member_friends', bp_get_friends_slug() ),
+                        'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_friends_requests', 'requests' ),
+                    )
+                )
+            ),
             'friend.id'           => $friend_id,
             'friendship.id'       => $friendship_id,
             'initiator.id'        => $initiator_id,
-            'initiator.url'       => esc_url( bp_core_get_user_domain( $initiator_id ) ),
+            'initiator.url'       => esc_url( bp_members_get_user_url( $initiator_id ) ),
             'initiator.name'      => bp_core_get_user_displayname( $initiator_id ),
             'unsubscribe'         => esc_url( bp_email_get_unsubscribe_link( $unsubscribe_args ) ),
@@ -916 +924 @@
         'tokens' => array(
             'friend.id'      => $friend_id,
-            'friendship.url' => esc_url( bp_core_get_user_domain( $friend_id ) ),
+            'friendship.url' => esc_url( bp_members_get_user_url( $friend_id ) ),
             'friend.name'    => bp_core_get_user_displayname( $friend_id ),
             'friendship.id'  => $friendship_id,