Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
03/07/2023 04:28:08 AM (14 months ago)
Author:
imath
Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

  1. to deprecate this function
  2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

  1. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes https://github.com/buddypress/buddypress/pull/70
See #4954

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-friends/bp-friends-blocks.php

    r13296 r13433  
    111111    $widget_id = uniqid( 'friends-list-' );
    112112
    113     $link = trailingslashit( bp_core_get_user_domain( $user_id ) . bp_get_friends_slug() );
     113    $link = bp_members_get_user_url(
     114        $user_id,
     115        array(
     116            'single_item_component' => bp_rewrites_get_slug( 'members', 'member_friends', bp_get_friends_slug() ),
     117        )
     118    );
    114119
    115120    /* translators: %s: member name */
     
    190195                    'php',
    191196                    array(
    192                         'data.link'              => bp_core_get_user_domain( $user->ID, $user->user_nicename, $user->user_login ),
     197                        'data.link'              => bp_members_get_user_url( $user->ID ),
    193198                        'data.name'              => $user->display_name,
    194199                        'data.avatar_urls.thumb' => bp_core_fetch_avatar(
Note: See TracChangeset for help on using the changeset viewer.