Changeset 13433 for trunk/src/bp-friends/bp-friends-blocks.php

Timestamp:

03/07/2023 04:28:08 AM (23 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-friends/bp-friends-blocks.php (modified) (2 diffs)

trunk/src/bp-friends/bp-friends-blocks.php

@@ -111 +111 @@
     $widget_id = uniqid( 'friends-list-' );
 
-    $link = trailingslashit( bp_core_get_user_domain( $user_id ) . bp_get_friends_slug() );
+    $link = bp_members_get_user_url(
+        $user_id,
+        array(
+            'single_item_component' => bp_rewrites_get_slug( 'members', 'member_friends', bp_get_friends_slug() ),
+        )
+    );
 
     /* translators: %s: member name */
@@ -190 +195 @@
                     'php',
                     array(
-                        'data.link'              => bp_core_get_user_domain( $user->ID, $user->user_nicename, $user->user_login ),
+                        'data.link'              => bp_members_get_user_url( $user->ID ),
                         'data.name'              => $user->display_name,
                         'data.avatar_urls.thumb' => bp_core_fetch_avatar(