Changeset 13433 for trunk/src/bp-core/bp-core-functions.php

Timestamp:

03/07/2023 04:28:08 AM (23 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-functions.php

@@ -4336 +4336 @@
 
         if ( bp_is_active( 'settings' ) ) {
-            $redirect_to = sprintf(
-                '%s%s/notifications/',
-                bp_core_get_user_domain( get_current_user_id() ),
-                bp_get_settings_slug()
+            $redirect_to = bp_members_get_user_url(
+                get_current_user_id(),
+                array(
+                    'single_item_component' => bp_rewrites_get_slug( 'members', 'member_settings', bp_get_settings_slug() ),
+                    'single_item_action'    => bp_rewrites_get_slug( 'members', 'member_settings_notifications', 'notifications' ),
+                )
             );
         } else {
-            $redirect_to = bp_core_get_user_domain( get_current_user_id() );
+            $redirect_to = bp_members_get_user_url( get_current_user_id() );
         }
 
@@ -4368 +4370 @@
             $redirect_to = sprintf(
                 '%s%s/notifications/',
-                bp_core_get_user_domain( $raw_user_id ),
+                bp_members_get_user_url( $raw_user_id ),
                 bp_get_settings_slug()
             );
         } else {
-            $redirect_to = bp_core_get_user_domain( $raw_user_id );
+            $redirect_to = bp_members_get_user_url( $raw_user_id );
         }
 
@@ -4393 +4395 @@
         // Template notices are only displayed on BP pages.
         bp_core_add_message( $message );
-        bp_core_redirect( bp_core_get_user_domain( $raw_user_id ) );
+        bp_core_redirect( bp_members_get_user_url( $raw_user_id ) );
 
         exit;