Changeset 13433 for trunk/src/bp-core/bp-core-filters.php

Timestamp:

03/07/2023 04:28:08 AM (3 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-core/bp-core-filters.php (modified) (2 diffs)

trunk/src/bp-core/bp-core-filters.php

@@ -292 +292 @@
 
     foreach( (array) $comments as $comment ) {
-        if ( $comment->user_id )
+        if ( $comment->user_id ) {
             $user_ids[] = $comment->user_id;
-    }
-
-    if ( empty( $user_ids ) )
+        }
+    }
+
+    if ( empty( $user_ids ) ) {
         return $comments;
+    }
 
     $user_ids = implode( ',', wp_parse_id_list( $user_ids ) );
 
-    if ( !$userdata = $wpdb->get_results( "SELECT ID as user_id, user_login, user_nicename FROM {$wpdb->users} WHERE ID IN ({$user_ids})" ) )
+    if ( ! $userdata = $wpdb->get_results( "SELECT ID as user_id, user_login, user_nicename FROM {$wpdb->users} WHERE ID IN ({$user_ids})" ) ) {
         return $comments;
-
-    foreach( (array) $userdata as $user )
-        $users[$user->user_id] = bp_core_get_user_domain( $user->user_id, $user->user_nicename, $user->user_login );
+    }
+
+    foreach( (array) $userdata as $user ) {
+        $users[$user->user_id] = bp_members_get_user_url( $user->user_id );
+    }
 
     foreach( (array) $comments as $i => $comment ) {
-        if ( !empty( $comment->user_id ) ) {
-            if ( !empty( $users[$comment->user_id] ) )
+        if ( ! empty( $comment->user_id ) ) {
+            if ( ! empty( $users[$comment->user_id] ) ) {
                 $comments[$i]->comment_author_url = $users[$comment->user_id];
+            }
         }
     }
@@ -1233 +1238 @@
                 $tokens['unsubscribe'] = esc_url( sprintf(
                     '%s%s/notifications/',
-                    bp_core_get_user_domain( $user_obj->ID ),
+                    bp_members_get_user_url( $user_obj->ID ),
                     bp_get_settings_slug()
                 ) );