Changeset 13433 for trunk/src/bp-activity/screens/permalink.php

Timestamp:

03/07/2023 04:28:08 AM (2 years ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-activity/screens/permalink.php (modified) (3 diffs)

trunk/src/bp-activity/screens/permalink.php

@@ -36 +36 @@
 
     // Do not redirect at default.
-    $redirect = false;
+    $redirect    = false;
+    $path_chunks = array(
+        'single_item_component' => bp_rewrites_get_slug( 'members', 'member_activity', bp_get_activity_slug() ),
+        'single_item_action'    => $activity->id,
+    );
 
     // Redirect based on the type of activity.
@@ -43 +47 @@
         // Activity is a user update.
         if ( ! empty( $activity->user_id ) ) {
-            $redirect = bp_core_get_user_domain( $activity->user_id, $activity->user_nicename, $activity->user_login ) . bp_get_activity_slug() . '/' . $activity->id . '/';
+            $redirect = bp_members_get_user_url( $activity->user_id, $path_chunks );
 
         // Activity is something else.
@@ -56 +60 @@
     // Set redirect to users' activity stream.
     } elseif ( ! empty( $activity->user_id ) ) {
-        $redirect = bp_core_get_user_domain( $activity->user_id, $activity->user_nicename, $activity->user_login ) . bp_get_activity_slug() . '/' . $activity->id . '/';
+        $redirect = bp_members_get_user_url( $activity->user_id, $path_chunks );
     }