Changeset 13433 for trunk/src/bp-activity/bp-activity-template.php

Timestamp:

03/07/2023 04:28:08 AM (21 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-activity/bp-activity-template.php (modified) (4 diffs)

trunk/src/bp-activity/bp-activity-template.php

@@ -1007 +1007 @@
             $link = $activities_template->activity->primary_link;
         } else {
-            $link = bp_core_get_user_domain( $activities_template->activity->user_id, $activities_template->activity->user_nicename, $activities_template->activity->user_login );
+            $link = bp_members_get_user_url( $activities_template->activity->user_id );
         }
 
@@ -1540 +1540 @@
             if ( in_array( $activity_type, array( 'new_avatar', 'new_member', 'friendship_created', 'updated_profile' ), true ) ) {
                 $generated_content->user_url = array(
-                    'value'             => bp_core_get_user_domain( $user_id ),
+                    'value'             => bp_members_get_user_url( $user_id ),
                     'sanitize_callback' => 'esc_url',
                 );
@@ -2255 +2255 @@
      */
     function bp_get_activity_comment_user_link() {
-        $user_link = bp_core_get_user_domain( bp_get_activity_comment_user_id() );
+        $user_link = bp_members_get_user_url( bp_get_activity_comment_user_id() );
 
         /**
@@ -3653 +3653 @@
 
             // Get profile link for this user.
-            $profile_link = bp_core_get_user_domain( $user_id );
+            $profile_link = bp_members_get_user_url( $user_id );
 
             // Get avatar for this user.