Changeset 13433 for trunk/src/bp-activity/bp-activity-filters.php

Timestamp:

03/07/2023 04:28:08 AM (19 months ago)

Author:

imath

Message:

BP Rewrites: Introduce the bp_members_get_user_url() function

As many member URLs are built concatenating bp_core_get_user_domain()
with URL chunks, the safer way to make sure developers update the way they
build their member URLs in favor of using BP Rewrites is:

1. to deprecate this function
2. create a new function bp_members_get_user_url() which is a wrapper of

bp_rewrites_get_url()

3. replace all bp_core_get_user_domain() occurrences by

bp_members_get_user_url()

This commit also deprecates bp_core_get_username() in favor of the new
bp_members_get_user_slug() function and updates PHPUnit tests.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/70
See #4954

File:

• trunk/src/bp-activity/bp-activity-filters.php (modified) (2 diffs)

trunk/src/bp-activity/bp-activity-filters.php

@@ -265 +265 @@
     // Linkify the mentions with the username.
     foreach ( (array) $usernames as $user_id => $username ) {
-        $content = preg_replace( '/(@' . $username . '\b)/', "<a class='bp-suggestions-mention' href='" . bp_core_get_user_domain( $user_id ) . "' rel='nofollow'>@$username</a>", $content );
+        $content = preg_replace( '/(@' . $username . '\b)/', "<a class='bp-suggestions-mention' href='" . bp_members_get_user_url( $user_id ) . "' rel='nofollow'>@$username</a>", $content );
     }
 
@@ -306 +306 @@
         // Replace @mention text with userlinks.
         foreach( (array) $usernames as $user_id => $username ) {
-            $activity->content = preg_replace( '/(@' . $username . '\b)/', "<a class='bp-suggestions-mention' href='" . bp_core_get_user_domain( $user_id ) . "' rel='nofollow'>@$username</a>", $activity->content );
+            $activity->content = preg_replace( '/(@' . $username . '\b)/', "<a class='bp-suggestions-mention' href='" . bp_members_get_user_url( $user_id ) . "' rel='nofollow'>@$username</a>", $activity->content );
         }