Changeset 13432 for trunk/src/bp-settings/screens/general.php

Timestamp:

03/01/2023 08:17:11 AM (3 years ago)

Author:

imath

Message:

BP Rewrites: introduce the bp_rewrites_get_url() function

Its role is to build every BuddyPress URL using the BP Rewrites API.

This commit also deprecates softly some key functions like bp_get_root_domain() to let us review (thanks to deprecated notices) all BuddyPress links during 12.0 development cycle and make them use the introduced bp_rewrites_get_url() function or a wrapper of it. Once all replacements achieved, we'll need to fully deprecate:

• bp_get_root_domain()
• bp_root_domain()
• bp_core_get_root_domain()

Slug constants have also been completely deprecated as we will be able to customize every slugs from the future "URL" tab of the BuddyPress settings page.

The $bp->root_domain BuddyPress global has been deprecated in favor of $bp->root_url.

Finally, the Components $rewrite_ids properties are now in place and corresponding rewrite rules are successfully generated.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/69
See #4954

File:

• trunk/src/bp-settings/screens/general.php (modified) (1 diff)

trunk/src/bp-settings/screens/general.php

@@ -37 +37 @@
 function bp_settings_remove_email_subnav() {
     if ( ! has_action( 'bp_notification_settings' ) ) {
-        bp_core_remove_subnav_item( BP_SETTINGS_SLUG, 'notifications' );
+        bp_core_remove_subnav_item( bp_get_settings_slug(), 'notifications' );
     }
 }