Changeset 13432 for trunk/src/bp-settings/classes/class-bp-settings-component.php

Timestamp:

03/01/2023 08:17:11 AM (4 years ago)

Author:

imath

Message:

BP Rewrites: introduce the bp_rewrites_get_url() function

Its role is to build every BuddyPress URL using the BP Rewrites API.

This commit also deprecates softly some key functions like bp_get_root_domain() to let us review (thanks to deprecated notices) all BuddyPress links during 12.0 development cycle and make them use the introduced bp_rewrites_get_url() function or a wrapper of it. Once all replacements achieved, we'll need to fully deprecate:

• bp_get_root_domain()
• bp_root_domain()
• bp_core_get_root_domain()

Slug constants have also been completely deprecated as we will be able to customize every slugs from the future "URL" tab of the BuddyPress settings page.

The $bp->root_domain BuddyPress global has been deprecated in favor of $bp->root_url.

Finally, the Components $rewrite_ids properties are now in place and corresponding rewrite rules are successfully generated.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/69
See #4954

File:

• trunk/src/bp-settings/classes/class-bp-settings-component.php (modified) (2 diffs)

trunk/src/bp-settings/classes/class-bp-settings-component.php

@@ -95 +95 @@
          * Setup globals.
          *
-         * The BP_SETTINGS_SLUG constant is deprecated, and only used here for
-         * backwards compatibility.
+         * The BP_SETTINGS_SLUG constant is deprecated.
          *
          * @since 1.5.0
@@ -105 +104 @@
          */
         public function setup_globals( $args = array() ) {
-
-                // Define a slug, if necessary.
-                if ( ! defined( 'BP_SETTINGS_SLUG' ) ) {
-                        define( 'BP_SETTINGS_SLUG', $this->id );
+                $default_slug = $this->id;
+
+                // @deprecated.
+                if ( defined( 'BP_SETTINGS_SLUG' ) ) {
+                        _doing_it_wrong( 'BP_SETTINGS_SLUG', esc_html__( 'Slug constants are deprecated.', 'buddypress' ), 'BuddyPress 12.0.0' );
+                        $default_slug = BP_SETTINGS_SLUG;
                 }
 
                 // All globals for settings component.
                 parent::setup_globals( array(
-                        'slug'          => BP_SETTINGS_SLUG,
+                        'slug'          => $default_slug,
                         'has_directory' => false,
                 ) );