Changeset 13432 for trunk/src/bp-members/classes/class-bp-members-component.php

Timestamp:

03/01/2023 08:17:11 AM (3 years ago)

Author:

imath

Message:

BP Rewrites: introduce the bp_rewrites_get_url() function

Its role is to build every BuddyPress URL using the BP Rewrites API.

This commit also deprecates softly some key functions like bp_get_root_domain() to let us review (thanks to deprecated notices) all BuddyPress links during 12.0 development cycle and make them use the introduced bp_rewrites_get_url() function or a wrapper of it. Once all replacements achieved, we'll need to fully deprecate:

• bp_get_root_domain()
• bp_root_domain()
• bp_core_get_root_domain()

Slug constants have also been completely deprecated as we will be able to customize every slugs from the future "URL" tab of the BuddyPress settings page.

The $bp->root_domain BuddyPress global has been deprecated in favor of $bp->root_url.

Finally, the Components $rewrite_ids properties are now in place and corresponding rewrite rules are successfully generated.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/69
See #4954

File:

• trunk/src/bp-members/classes/class-bp-members-component.php (modified) (3 diffs)

trunk/src/bp-members/classes/class-bp-members-component.php

@@ -276 +276 @@
      * Set up bp-members global settings.
      *
-     * The BP_MEMBERS_SLUG constant is deprecated, and only used here for
-     * backwards compatibility.
+     * The BP_MEMBERS_SLUG constant is deprecated.
      *
      * @since 1.5.0
@@ -288 +287 @@
         global $wpdb;
 
-        $bp = buddypress();
+        $bp           = buddypress();
+        $default_slug = $this->id;
 
         /** Component Globals ************************************************
          */
 
-        // Define a slug, as a fallback for backpat.
-        if ( !defined( 'BP_MEMBERS_SLUG' ) ) {
-            define( 'BP_MEMBERS_SLUG', $this->id );
+        // @deprecated.
+        if ( defined( 'BP_MEMBERS_SLUG' ) ) {
+            _doing_it_wrong( 'BP_MEMBERS_SLUG', esc_html__( 'Slug constants are deprecated.', 'buddypress' ), 'BuddyPress 12.0.0' );
+            $default_slug = BP_MEMBERS_SLUG;
         }
 
@@ -304 +305 @@
         // Override any passed args.
         $args = array(
-            'slug'            => BP_MEMBERS_SLUG,
-            'root_slug'       => isset( $bp->pages->members->slug ) ? $bp->pages->members->slug : BP_MEMBERS_SLUG,
+            'slug'            => $default_slug,
+            'root_slug'       => isset( $bp->pages->members->slug ) ? $bp->pages->members->slug : $default_slug,
             'has_directory'   => true,
+            'rewrite_ids'     => array(
+                'directory'                    => 'members',
+                'directory_type'               => 'members_type',
+                'single_item'                  => 'member',
+                'single_item_component'        => 'member_component',
+                'single_item_action'           => 'member_action',
+                'single_item_action_variables' => 'member_action_variables',
+                'member_register'              => 'register',
+                'member_activate'              => 'activate',
+                'member_activate_key'          => 'activate_key',
+            ),
             'directory_title' => isset( $bp->pages->members->title ) ? $bp->pages->members->title : $default_directory_title,
             'search_string'   => __( 'Search Members...', 'buddypress' ),