Changeset 13432 for trunk/src/bp-members/bp-members-template.php

Timestamp:

03/01/2023 08:17:11 AM (3 years ago)

Author:

imath

Message:

BP Rewrites: introduce the bp_rewrites_get_url() function

Its role is to build every BuddyPress URL using the BP Rewrites API.

This commit also deprecates softly some key functions like bp_get_root_domain() to let us review (thanks to deprecated notices) all BuddyPress links during 12.0 development cycle and make them use the introduced bp_rewrites_get_url() function or a wrapper of it. Once all replacements achieved, we'll need to fully deprecate:

• bp_get_root_domain()
• bp_root_domain()
• bp_core_get_root_domain()

Slug constants have also been completely deprecated as we will be able to customize every slugs from the future "URL" tab of the BuddyPress settings page.

The $bp->root_domain BuddyPress global has been deprecated in favor of $bp->root_url.

Finally, the Components $rewrite_ids properties are now in place and corresponding rewrite rules are successfully generated.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/69
See #4954

File:

• trunk/src/bp-members/bp-members-template.php (modified) (2 diffs)

trunk/src/bp-members/bp-members-template.php

@@ -214 +214 @@
      */
     function bp_get_signup_slug() {
-        $bp = buddypress();
+        $bp   = buddypress();
+        $slug = 'register';
 
         if ( ! empty( $bp->pages->register->slug ) ) {
             $slug = $bp->pages->register->slug;
-        } elseif ( defined( 'BP_REGISTER_SLUG' ) ) {
-            $slug = BP_REGISTER_SLUG;
-        } else {
-            $slug = 'register';
         }
 
@@ -250 +247 @@
      */
     function bp_get_activate_slug() {
-        $bp = buddypress();
+        $bp   = buddypress();
+        $slug = 'activate';
 
         if ( ! empty( $bp->pages->activate->slug ) ) {
             $slug = $bp->pages->activate->slug;
-        } elseif ( defined( 'BP_ACTIVATION_SLUG' ) ) {
-            $slug = BP_ACTIVATION_SLUG;
-        } else {
-            $slug = 'activate';
         }