Changeset 13432 for trunk/src/bp-groups/classes/class-bp-groups-component.php

Timestamp:

03/01/2023 08:17:11 AM (3 years ago)

Author:

imath

Message:

BP Rewrites: introduce the bp_rewrites_get_url() function

Its role is to build every BuddyPress URL using the BP Rewrites API.

This commit also deprecates softly some key functions like bp_get_root_domain() to let us review (thanks to deprecated notices) all BuddyPress links during 12.0 development cycle and make them use the introduced bp_rewrites_get_url() function or a wrapper of it. Once all replacements achieved, we'll need to fully deprecate:

• bp_get_root_domain()
• bp_root_domain()
• bp_core_get_root_domain()

Slug constants have also been completely deprecated as we will be able to customize every slugs from the future "URL" tab of the BuddyPress settings page.

The $bp->root_domain BuddyPress global has been deprecated in favor of $bp->root_url.

Finally, the Components $rewrite_ids properties are now in place and corresponding rewrite rules are successfully generated.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/69
See #4954

File:

• trunk/src/bp-groups/classes/class-bp-groups-component.php (modified) (3 diffs)

trunk/src/bp-groups/classes/class-bp-groups-component.php

@@ -439 +439 @@
          * Set up component global data.
          *
-         * The BP_GROUPS_SLUG constant is deprecated, and only used here for
-         * backwards compatibility.
+         * The BP_GROUPS_SLUG constant is deprecated.
          *
          * @since 1.5.0
@@ -449 +448 @@
          */
         public function setup_globals( $args = array() ) {
-                $bp = buddypress();
-
-                // Define a slug, if necessary.
-                if ( ! defined( 'BP_GROUPS_SLUG' ) ) {
-                        define( 'BP_GROUPS_SLUG', $this->id );
+                $bp           = buddypress();
+                $default_slug = $this->id;
+
+                // @deprecated.
+                if ( defined( 'BP_GROUPS_SLUG' ) ) {
+                        _doing_it_wrong( 'BP_GROUPS_SLUG', esc_html__( 'Slug constants are deprecated.', 'buddypress' ), 'BuddyPress 12.0.0' );
+                        $default_slug = BP_GROUPS_SLUG;
                 }
 
@@ -475 +476 @@
                 // Note that global_tables is included in this array.
                 $args = array(
-                        'slug'                  => BP_GROUPS_SLUG,
-                        'root_slug'             => isset( $bp->pages->groups->slug ) ? $bp->pages->groups->slug : BP_GROUPS_SLUG,
+                        'slug'                  => $default_slug,
+                        'root_slug'             => isset( $bp->pages->groups->slug ) ? $bp->pages->groups->slug : $default_slug,
                         'has_directory'         => true,
+                        'rewrite_ids'           => array(
+                                'directory'                    => 'groups',
+                                'directory_type'               => 'groups_type',
+                                'create_single_item'           => 'group_create',
+                                'create_single_item_variables' => 'group_create_variables',
+                                'single_item'                  => 'group',
+                                'single_item_action'           => 'group_action',
+                                'single_item_action_variables' => 'group_action_variables',
+                        ),
                         'directory_title'       => isset( $bp->pages->groups->title ) ? $bp->pages->groups->title : $default_directory_title,
                         'notification_callback' => 'groups_format_notifications',