Changeset 13431 for trunk/src/bp-core/admin/bp-core-admin-functions.php

Timestamp:

02/24/2023 09:37:44 AM (3 years ago)

Author:

imath

Message:

Use a custom post type instead of the page post type for directories

• The buddypress post type is now the one used for the BP component

directory page.

• Introduce the bp_core_set_unique_directory_page_slug() function to

make sure there is no conflict with an existing WP page when setting the
BP Component directory page post_name.

• Introduce the bp_restricted custom status. We'll be able to use it for

future visibility features.

• Deprecate the Admin Slugs screen and corresponding functions
• Bump raw_db_version to 13422 (the first commit about merging BP

Rewrites).

• Add an update function to update the post type of the existing BP

component directory pages and potential WP Nav Menus including these.

Props r-a-y, johnjamesjacoby, boonebgorges

Closes ​https://github.com/buddypress/buddypress/pull/67
See #4954

File:

• trunk/src/bp-core/admin/bp-core-admin-functions.php (modified) (3 diffs)

trunk/src/bp-core/admin/bp-core-admin-functions.php

@@ -310 +310 @@
 
         if ( ! empty( $orphaned_components ) ) {
-                $admin_url = bp_get_admin_url( add_query_arg( array( 'page' => 'bp-page-settings' ), 'admin.php' ) );
-                $notice    = sprintf(
-                        '%1$s <a href="%2$s">%3$s</a>',
-                        sprintf(
-                                // Translators: %s is the comma separated list of components needing a directory page.
-                                __( 'The following active BuddyPress Components do not have associated WordPress Pages: %s.', 'buddypress' ),
-                                '<strong>' . implode( '</strong>, <strong>', array_map( 'esc_html', $orphaned_components ) ) . '</strong>'
-                        ),
-                        esc_url( $admin_url ),
-                        __( 'Repair', 'buddypress' )
+                $notice = sprintf(
+                        // Translators: %s is the comma separated list of components needing a directory page.
+                        __( 'The following active BuddyPress Components do not have associated BuddyPress Pages: %s.', 'buddypress' ),
+                        '<strong>' . implode( '</strong>, <strong>', array_map( 'esc_html', $orphaned_components ) ) . '</strong>'
                 );
 
@@ -341 +335 @@
         // If there are duplicates, post a message about them.
         if ( ! empty( $dupe_names ) ) {
-                $admin_url = bp_get_admin_url( add_query_arg( array( 'page' => 'bp-page-settings' ), 'admin.php' ) );
-                $notice    = sprintf(
-                        '%1$s <a href="%2$s">%3$s</a>',
-                        sprintf(
-                                // Translators: %s is the list of directory pages associated to more than one component.
-                                __( 'Each BuddyPress Component needs its own WordPress page. The following WordPress Pages have more than one component associated with them: %s.', 'buddypress' ),
-                                '<strong>' . implode( '</strong>, <strong>', array_map( 'esc_html', $dupe_names ) ) . '</strong>'
-                        ),
-                        esc_url( $admin_url ),
-                        __( 'Repair', 'buddypress' )
+                $notice = ssprintf(
+                        // Translators: %s is the list of directory pages associated to more than one component.
+                        __( 'Each BuddyPress Component needs its own BuddyPress page. The following BuddyPress Pages have more than one component associated with them: %s.', 'buddypress' ),
+                        '<strong>' . implode( '</strong>, <strong>', array_map( 'esc_html', $dupe_names ) ) . '</strong>'
                 );
 
@@ -506 +494 @@
                         'href' => bp_get_admin_url( add_query_arg( array( 'page' => 'bp-settings' ), 'admin.php' ) ),
                         'name' => __( 'Options', 'buddypress' ),
-                ),
-                '1' => array(
-                        'id'   => 'bp-page-settings',
-                        'href' => bp_get_admin_url( add_query_arg( array( 'page' => 'bp-page-settings' ), 'admin.php' ) ),
-                        'name' => __( 'Pages', 'buddypress' ),
                 ),
                 '3' => array(