Changeset 13415

Timestamp:

02/10/2023 03:40:41 AM (3 years ago)

Author:

imath

Message:

BP Nouveau: Make sure the thread ID is transported into thread view

The Backbone based Messages UI of the Nouveau template pack is now looking for the displayed thread ID inside the messages collection if the current thread object hasn't been returned by the Ajax request. This prevent an error that was happening when trying to reply to a thread message after the thread has been displayed without re-requesting the server.

Props casper99

Closes ​https://github.com/buddypress/buddypress/pull/63
See #8825

Location:

trunk/src/bp-templates/bp-nouveau

Files:

• buddypress/common/js-templates/messages/index.php (modified) (1 diff)
• js/buddypress-messages.js (modified) (3 diffs)

trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/messages/index.php

@@ -156 +156 @@
                 <div class="thread-subject">
                         <span class="thread-count">({{data.count}})</span>
-                        <a class="subject" href="../view/{{data.id}}/">{{data.subject}}</a>
+                        <a class="subject" href="./view/{{data.id}}/">{{data.subject}}</a>
                 </div>
                 <p class="excerpt">{{data.excerpt}}</p>

trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js

@@ -1355 +1355 @@
 
                 messagesFetched: function( collection, response ) {
-                        if ( ! _.isUndefined( response.thread ) ) {
+                        if ( response.thread && !! response.thread.length ) {
                                 this.options.thread = new Backbone.Model( response.thread );
                         }
@@ -1380 +1380 @@
 
                 sendReply: function( event ) {
+                        var threadItem;
                         event.preventDefault();
 
@@ -1386 +1387 @@
                         }
 
+                        threadItem = this.options.thread;
+                        if ( ! threadItem.has( 'id' ) ) {
+                                threadItem = this.options.collection.at( 0 );
+                        }
+
                         this.reply.set ( {
-                                thread_id : this.options.thread.get( 'id' ),
+                                thread_id : threadItem.get( 'id' ),
                                 content   : tinyMCE.activeEditor.getContent(),
                                 sending   : true