Changeset 13414

Timestamp:

02/10/2023 03:12:09 AM (22 months ago)

Author:

imath

Message:

Improve PHP 8.2 compatibility

• Add the #[AllowDynamicProperties] attribute to classes when we add dynamic properties to these into our codebase.
• Add PHP 8.2 to our PHPUnit testing matrix

Closes ​https://github.com/buddypress/buddypress/pull/62
Fixes #8820

Location:

trunk

Files:

• .github/workflows/unit-tests.yml (modified) (1 diff)
• src/bp-activity/classes/class-bp-activity-activity.php (modified) (7 diffs)
• src/bp-activity/classes/class-bp-activity-component.php (modified) (1 diff)
• src/bp-blogs/classes/class-bp-blogs-blog.php (modified) (1 diff)
• src/bp-blogs/classes/class-bp-blogs-component.php (modified) (1 diff)
• src/bp-core/classes/class-bp-admin.php (modified) (1 diff)
• src/bp-core/classes/class-bp-attachment-avatar.php (modified) (1 diff)
• src/bp-core/classes/class-bp-attachment-cover-image.php (modified) (1 diff)
• src/bp-core/classes/class-bp-core.php (modified) (1 diff)
• src/bp-core/classes/class-bp-media-extractor.php (modified) (1 diff)
• src/bp-friends/classes/class-bp-friends-component.php (modified) (1 diff)
• src/bp-friends/classes/class-bp-friends-friendship.php (modified) (1 diff)
• src/bp-groups/classes/class-bp-groups-component.php (modified) (1 diff)
• src/bp-groups/classes/class-bp-groups-group.php (modified) (1 diff)
• src/bp-members/classes/class-bp-core-members-template.php (modified) (1 diff)
• src/bp-members/classes/class-bp-members-component.php (modified) (1 diff)
• src/bp-members/classes/class-bp-signup.php (modified) (1 diff)
• src/bp-messages/classes/class-bp-messages-box-template.php (modified) (1 diff)
• src/bp-messages/classes/class-bp-messages-component.php (modified) (1 diff)
• src/bp-messages/classes/class-bp-messages-message.php (modified) (1 diff)
• src/bp-messages/classes/class-bp-messages-notice.php (modified) (1 diff)
• src/bp-messages/classes/class-bp-messages-notices-admin.php (modified) (1 diff)
• src/bp-messages/classes/class-bp-messages-thread.php (modified) (1 diff)
• src/bp-notifications/classes/class-bp-notifications-component.php (modified) (1 diff)
• src/bp-notifications/classes/class-bp-notifications-notification.php (modified) (1 diff)
• src/bp-settings/classes/class-bp-settings-component.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/activity/loader.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/blogs/loader.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/classes/class-bp-buttons-group.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/friends/loader.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/groups/classes.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/groups/loader.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/members/loader.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/messages/loader.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/notifications/loader.php (modified) (1 diff)
• src/bp-templates/bp-nouveau/includes/xprofile/loader.php (modified) (1 diff)
• src/bp-xprofile/classes/class-bp-xprofile-component.php (modified) (1 diff)
• src/bp-xprofile/classes/class-bp-xprofile-field.php (modified) (5 diffs)
• src/bp-xprofile/classes/class-bp-xprofile-group.php (modified) (1 diff)
• src/bp-xprofile/classes/class-bp-xprofile-profiledata.php (modified) (1 diff)
• tests/phpunit/assets/attachment-extensions.php (modified) (1 diff)
• tests/phpunit/assets/bp-rest-api-controllers.php (modified) (4 diffs)
• tests/phpunit/includes/factory.php (modified) (1 diff)
• tests/phpunit/testcases/activity/functions.php (modified) (1 diff)
• tests/phpunit/testcases/activity/functions/bpActivityGetActionsForContext.php (modified) (1 diff)
• tests/phpunit/testcases/activity/notifications.php (modified) (1 diff)
• tests/phpunit/testcases/blogs/functions.php (modified) (1 diff)
• tests/phpunit/testcases/core/class-bp-attachment.php (modified) (1 diff)
• tests/phpunit/testcases/groups/class-bp-groups-group.php (modified) (1 diff)
• tests/phpunit/testcases/groups/template.php (modified) (1 diff)
• tests/phpunit/testcases/groups/template/group-is-visible.php (modified) (1 diff)
• tests/phpunit/testcases/members/functions.php (modified) (1 diff)
• tests/phpunit/testcases/messages/cache.php (modified) (1 diff)
• tests/phpunit/testcases/messages/notifications.php (modified) (1 diff)
• tests/phpunit/testcases/notifications/functions.php (modified) (1 diff)
• tests/phpunit/testcases/xprofile/class-bp-xprofile-profiledata.php (modified) (1 diff)

trunk/.github/workflows/unit-tests.yml

@@ -13 +13 @@
       fail-fast: false
       matrix:
-        php: ['7.4', '8.0', '8.1']
+        php: ['7.4', '8.0', '8.1', '8.2']
         wp_version: ['master']
         include:

trunk/src/bp-activity/classes/class-bp-activity-activity.php

@@ -18 +18 @@
  * @since 1.0.0
  */
+#[AllowDynamicProperties]
 class BP_Activity_Activity {
 
@@ -60 +61 @@
      * @var string
      */
-    var $primary_link;
+    var $primary_link = '';
 
     /**
@@ -68 +69 @@
      * @var string
      */
-    var $component;
+    var $component = '';
 
     /**
@@ -76 +77 @@
      * @var string
      */
-    var $type;
+    var $type = '';
 
     /**
@@ -84 +85 @@
      * @var string
      */
-    var $action;
+    var $action = '';
 
     /**
@@ -92 +93 @@
      * @var string
      */
-    var $content;
+    var $content = '';
 
     /**
@@ -100 +101 @@
      * @var string
      */
-    var $date_recorded;
+    var $date_recorded = '';
 
     /**

trunk/src/bp-activity/classes/class-bp-activity-component.php

@@ -18 +18 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Activity_Component extends BP_Component {
 

trunk/src/bp-blogs/classes/class-bp-blogs-blog.php

@@ -19 +19 @@
  * @since 1.0.0
  */
+#[AllowDynamicProperties]
 class BP_Blogs_Blog {
 

trunk/src/bp-blogs/classes/class-bp-blogs-component.php

@@ -17 +17 @@
 /**
  * Creates our Blogs component.
+ *
+ * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Blogs_Component extends BP_Component {
 

trunk/src/bp-core/classes/class-bp-admin.php

@@ -20 +20 @@
  * @since 1.6.0
  */
+#[AllowDynamicProperties]
 class BP_Admin {
 

trunk/src/bp-core/classes/class-bp-attachment-avatar.php

@@ -18 +18 @@
  * @since 2.3.0
  */
+#[AllowDynamicProperties]
 class BP_Attachment_Avatar extends BP_Attachment {
 

trunk/src/bp-core/classes/class-bp-attachment-cover-image.php

@@ -18 +18 @@
  * @since 2.4.0
  */
+#[AllowDynamicProperties]
 class BP_Attachment_Cover_Image extends BP_Attachment {
     /**

trunk/src/bp-core/classes/class-bp-core.php

@@ -18 +18 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Core extends BP_Component {
 

trunk/src/bp-core/classes/class-bp-media-extractor.php

@@ -643 +643 @@
 
             foreach ( $links['links'] as $link ) {
-                $path = untrailingslashit( parse_url( $link['url'], PHP_URL_PATH ) );
+                $path = parse_url( $link['url'], PHP_URL_PATH );
 
                 // Check this URL's file extension matches that of an accepted audio format.
-                if ( ! $path || substr( $path, -4 ) !== $extension ) {
+                if ( ! $path || substr( untrailingslashit( $path ), -4 ) !== $extension ) {
                     continue;
                 }

trunk/src/bp-friends/classes/class-bp-friends-component.php

@@ -18 +18 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Friends_Component extends BP_Component {
 

trunk/src/bp-friends/classes/class-bp-friends-friendship.php

@@ -16 +16 @@
  * @since 1.0.0
  */
+#[AllowDynamicProperties]
 class BP_Friends_Friendship {
 

trunk/src/bp-groups/classes/class-bp-groups-component.php

@@ -16 +16 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Groups_Component extends BP_Component {
 

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -16 +16 @@
  * @since 1.6.0
  */
+#[AllowDynamicProperties]
 class BP_Groups_Group {
 

trunk/src/bp-members/classes/class-bp-core-members-template.php

@@ -162 +162 @@
             'max'                 => false,
             'user_id'             => false,
-            'search_terms'        => null,
+            'search_terms'        => '',
             'include'             => false,
             'populate_extras'     => true,

trunk/src/bp-members/classes/class-bp-members-component.php

@@ -16 +16 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Members_Component extends BP_Component {
 

trunk/src/bp-members/classes/class-bp-signup.php

@@ -13 +13 @@
  * @since 2.0.0
  */
+#[AllowDynamicProperties]
 class BP_Signup {
 

trunk/src/bp-messages/classes/class-bp-messages-box-template.php

@@ -14 +14 @@
  * Message Box Template Class
  */
+#[AllowDynamicProperties]
 class BP_Messages_Box_Template {
 

trunk/src/bp-messages/classes/class-bp-messages-component.php

@@ -18 +18 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Messages_Component extends BP_Component {
 

trunk/src/bp-messages/classes/class-bp-messages-message.php

@@ -14 +14 @@
  * Single message class.
  */
+#[AllowDynamicProperties]
 class BP_Messages_Message {
 

trunk/src/bp-messages/classes/class-bp-messages-notice.php

@@ -18 +18 @@
  * @since 1.0.0
  */
+#[AllowDynamicProperties]
 class BP_Messages_Notice {
 

trunk/src/bp-messages/classes/class-bp-messages-notices-admin.php

@@ -14 +14 @@
  * BuddyPress Notices Admin class.
  */
+#[AllowDynamicProperties]
 class BP_Messages_Notices_Admin {
 

trunk/src/bp-messages/classes/class-bp-messages-thread.php

@@ -16 +16 @@
  * @since 1.0.0
  */
+#[AllowDynamicProperties]
 class BP_Messages_Thread {
 

trunk/src/bp-notifications/classes/class-bp-notifications-component.php

@@ -15 +15 @@
 /**
  * Extends the component class to set up the Notifications component.
+ *
+ * @since 1.9.0
  */
+#[AllowDynamicProperties]
 class BP_Notifications_Component extends BP_Component {
 

trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

@@ -20 +20 @@
  * @since 1.9.0
  */
+#[AllowDynamicProperties]
 class BP_Notifications_Notification {
 

trunk/src/bp-settings/classes/class-bp-settings-component.php

@@ -16 +16 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_Settings_Component extends BP_Component {
 

trunk/src/bp-templates/bp-nouveau/includes/activity/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Activity {
     /**

trunk/src/bp-templates/bp-nouveau/includes/blogs/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Blogs {
     /**

trunk/src/bp-templates/bp-nouveau/includes/classes/class-bp-buttons-group.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Buttons_Group {
 

trunk/src/bp-templates/bp-nouveau/includes/friends/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Friends {
     /**

trunk/src/bp-templates/bp-nouveau/includes/groups/classes.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Group_Invite_Query extends BP_User_Query {
     /**

trunk/src/bp-templates/bp-nouveau/includes/groups/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Groups {
     /**

trunk/src/bp-templates/bp-nouveau/includes/members/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Members {
     /**

trunk/src/bp-templates/bp-nouveau/includes/messages/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Messages {
     /**

trunk/src/bp-templates/bp-nouveau/includes/notifications/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_Notifications {
     /**

trunk/src/bp-templates/bp-nouveau/includes/xprofile/loader.php

@@ -15 +15 @@
  * @since 3.0.0
  */
+#[AllowDynamicProperties]
 class BP_Nouveau_xProfile {
     /**

trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php

@@ -19 +19 @@
  * @since 1.5.0
  */
+#[AllowDynamicProperties]
 class BP_XProfile_Component extends BP_Component {
 

trunk/src/bp-xprofile/classes/class-bp-xprofile-field.php

@@ -16 +16 @@
  * @since 1.0.0
  */
+#[AllowDynamicProperties]
 class BP_XProfile_Field {
 
@@ -48 +49 @@
      * @var string
      */
-    public $type;
+    public $type = '';
 
     /**
@@ -56 +57 @@
      * @var string
      */
-    public $name;
+    public $name = '';
 
     /**
@@ -64 +65 @@
      * @var string
      */
-    public $description;
+    public $description = '';
 
     /**
@@ -104 +105 @@
      * @var string
      */
-    public $order_by;
+    public $order_by = '';
 
     /**

trunk/src/bp-xprofile/classes/class-bp-xprofile-group.php

@@ -16 +16 @@
  * @since 1.0.0
  */
+#[AllowDynamicProperties]
 class BP_XProfile_Group {
 

trunk/src/bp-xprofile/classes/class-bp-xprofile-profiledata.php

@@ -16 +16 @@
  * @since 1.6.0
  */
+#[AllowDynamicProperties]
 class BP_XProfile_ProfileData {
 

trunk/tests/phpunit/assets/attachment-extensions.php

@@ -4 +4 @@
  * for our unit tests
  */
+#[AllowDynamicProperties]
 class BPTest_Attachment_Extension extends BP_Attachment {
     public function __construct( $args = array() ) {

trunk/tests/phpunit/assets/bp-rest-api-controllers.php

@@ -15 +15 @@
  * BP Member Cover Image REST Controller's mock.
  */
+#[AllowDynamicProperties]
 class BP_REST_Attachments_Member_Cover_Endpoint extends BP_REST_Mock_Class {
     public function __construct() {
@@ -29 +30 @@
  * BP Member Avatar REST Controller's mock.
  */
+#[AllowDynamicProperties]
 class BP_REST_Attachments_Member_Avatar_Endpoint extends BP_REST_Mock_Class {
     public function __construct() {
@@ -43 +45 @@
  * BP Components REST Controller's mock.
  */
+#[AllowDynamicProperties]
 class BP_REST_Components_Endpoint extends BP_REST_Mock_Class {
     public function __construct() {
@@ -57 +60 @@
  * BP Members REST Controller's mock.
  */
+#[AllowDynamicProperties]
 class BP_REST_Members_Endpoint extends BP_REST_Mock_Class {
     public function __construct() {

trunk/tests/phpunit/includes/factory.php

@@ -1 +1 @@
 <?php
+#[AllowDynamicProperties]
 class BP_UnitTest_Factory extends WP_UnitTest_Factory {
     public $activity = null;

trunk/tests/phpunit/testcases/activity/functions.php

@@ -3 +3 @@
  * @group activity
  */
+#[AllowDynamicProperties]
 class BP_Tests_Activity_Functions extends BP_UnitTestCase {
 

trunk/tests/phpunit/testcases/activity/functions/bpActivityGetActionsForContext.php

@@ -4 +4 @@
  * @group activity
  */
+#[AllowDynamicProperties]
 class BP_Tests_Activity_Functions_BpActivityGetActionsForContext extends BP_UnitTestCase {
     public function set_up() {

trunk/tests/phpunit/testcases/activity/notifications.php

@@ -5 +5 @@
  * @group notifications
  */
+#[AllowDynamicProperties]
 class BP_Tests_Activity_Notifications extends BP_UnitTestCase {
     protected $current_user;

trunk/tests/phpunit/testcases/blogs/functions.php

@@ -4 +4 @@
  * @group blogs
  */
+#[AllowDynamicProperties]
 class BP_Tests_Blogs_Functions extends BP_UnitTestCase {
     /**

trunk/tests/phpunit/testcases/core/class-bp-attachment.php

@@ -7 +7 @@
  * @group BP_Attachment
  */
+#[AllowDynamicProperties]
 class BP_Tests_BP_Attachment_TestCases extends BP_UnitTestCase {
     private $upload_results;

trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -4 +4 @@
  * @group BP_Groups_Group
  */
+#[AllowDynamicProperties]
 class BP_Tests_BP_Groups_Group_TestCases extends BP_UnitTestCase {
 

trunk/tests/phpunit/testcases/groups/template.php

@@ -4 +4 @@
  * @group template
  */
+#[AllowDynamicProperties]
 class BP_Tests_Groups_Template extends BP_UnitTestCase {
 

trunk/tests/phpunit/testcases/groups/template/group-is-visible.php

@@ -5 +5 @@
  * @group template
  */
+#[AllowDynamicProperties]
 class BP_Tests_Groups_Template_Is_Visible extends BP_UnitTestCase {
 

trunk/tests/phpunit/testcases/members/functions.php

@@ -3 +3 @@
  * @group members
  */
+#[AllowDynamicProperties]
 class BP_Tests_Members_Functions extends BP_UnitTestCase {
 

trunk/tests/phpunit/testcases/messages/cache.php

@@ -5 +5 @@
  * @group cache
  */
+#[AllowDynamicProperties]
 class BP_Tests_Message_Cache extends BP_UnitTestCase {
     /**

trunk/tests/phpunit/testcases/messages/notifications.php

@@ -5 +5 @@
  * @group messages
  */
+#[AllowDynamicProperties]
 class BP_Tests_Messages_Notifications extends BP_UnitTestCase {
 

trunk/tests/phpunit/testcases/notifications/functions.php

@@ -4 +4 @@
  * @group notifications
  */
+#[AllowDynamicProperties]
 class BP_Tests_Notifications_Functions extends BP_UnitTestCase {
 

trunk/tests/phpunit/testcases/xprofile/class-bp-xprofile-profiledata.php

@@ -5 +5 @@
  * @group BP_XProfile_ProfileData
  */
+#[AllowDynamicProperties]
 class BP_Tests_BP_XProfile_ProfileData_TestCases extends BP_UnitTestCase {
     /**