Changeset 13355 for trunk/src/bp-groups/classes/class-bp-groups-group.php

Timestamp:

11/05/2022 05:25:42 AM (3 years ago)

Author:

imath

Message:

Update the GH action WP testing matrix, WP PHPunit and @wordpress/env

This commit also fixes:

• a GH action issue when testing WP < 6.1. In this case we need to downgrade WP PHPunit to a version lower than 6.1.0 to avoid @wordpress/env unit test command to fail (Internal Server Error).
• the database error when running the BP_Tests_Groups_Functions test.

Closes ​https://github.com/buddypress/buddypress/pull/34
Fixes #8759

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (2 diffs)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -395 +395 @@
 
         // Fetch the user IDs of all the members of the group.
-        $user_ids    = BP_Groups_Member::get_group_member_ids( $this->id );
-        $user_id_str = esc_sql( implode( ',', wp_parse_id_list( $user_ids ) ) );
-
-        // Modify group count usermeta for members.
-        $wpdb->query( "UPDATE {$wpdb->usermeta} SET meta_value = meta_value - 1 WHERE meta_key = 'total_group_count' AND user_id IN ( {$user_id_str} )" );
+        $user_ids = BP_Groups_Member::get_group_member_ids( $this->id );
+
+        if ( $user_ids ) {
+            $user_id_str = esc_sql( implode( ',', wp_parse_id_list( $user_ids ) ) );
+
+            // Modify group count usermeta for members.
+            $wpdb->query( "UPDATE {$wpdb->usermeta} SET meta_value = meta_value - 1 WHERE meta_key = 'total_group_count' AND user_id IN ( {$user_id_str} )" );
+        }
 
         // Now delete all group member entries.
@@ -419 +422 @@
 
         // Finally remove the group entry from the DB.
-        if ( !$wpdb->query( $wpdb->prepare( "DELETE FROM {$bp->groups->table_name} WHERE id = %d", $this->id ) ) )
+        if ( ! $wpdb->query( $wpdb->prepare( "DELETE FROM {$bp->groups->table_name} WHERE id = %d", $this->id ) ) ) {
             return false;
+        }
 
         return true;